Typo : With opcache.optimization_level=0xffffffef the result is "value".

Wrong package : Opcache

Thank you for this bug report. To properly diagnose the problem, we
need a short but complete example script to be able to reproduce
this bug ourselves. 

A proper reproducing script starts with <?php and ends with ?>,
is max. 10-20 lines long and does not require any external 
resources such as databases, etc. If the script requires a 
database to demonstrate the issue, please make sure it creates 
all necessary tables, stored procedures etc.

Please avoid embedding huge scripts into the report.

hmm, are you able to get the compiled SPIP view file?  it must be a PHP script which can be used to reproduce this problem?

Hi Laurence,

Here is a script that show the bug in action :

<h1>APC BUG</h1>
<?php
// Expected :
// APC BUG
// This should echo empty string: ><
// This should echo "tutu" string: >tutu<

// Works as expected with opcache.optimization_level=0xffffffef in php.ini


function table_valeur($table, $cle, $defaut='') {
    foreach (explode('/', $cle) as $k) {

        $table = is_string($table) ? @unserialize($table) : $table;

        if (is_object($table)) {
            $table =  (($k !== "") and isset($table->$k)) ? $table->$k : $defaut;
        } elseif (is_array($table)) {
            $table = isset($table[$k]) ? $table[$k] : $defaut;
        } else {
            $table = $defaut;
        }
    }
    return $table;
}

function vide($texte){
    return "";
}

echo "This should echo empty string: &gt;".vide($Pile['vars'][(string)'toto'] = 'tutu')."&lt;<br />";
echo "This should echo \"tutu\" string: &gt;".table_valeur($Pile['vars'],'toto')."&lt;<br />";

?>

Hi again Laruence,

We found that the problem comes form the cast in $Pile['vars'][(string)'toto']. With this news test script it works as expected :

<h1>APC BUG</h1>
<?php
// Expected :
// APC BUG
// This should echo empty string: ><
// This should echo "tutu" string: >tutu<

// Works as expected with opcache.optimization_level=0xffffffef in php.ini


function table_valeur($table, $cle, $defaut='') {
var_dump($table);
var_dump($cle);
var_dump($table[$cle]);
    foreach (explode('/', $cle) as $k) {

        $table = is_string($table) ? @unserialize($table) : $table;

        if (is_object($table)) {
            $table =  (($k !== "") and isset($table->$k)) ? $table->$k : $defaut;
        } elseif (is_array($table)) {
            $table = isset($table[$k]) ? $table[$k] : $defaut;
        } else {
            $table = $defaut;
        }
    }
    return $table;
}

function vide($texte){
    return "";
}

echo "This should echo empty string: &gt;".vide($Pile['vars']['toto'] = 'tutu')."&lt;<br />";
echo "This should echo \"tutu\" string: &gt;".table_valeur($Pile['vars'],'toto')."&lt;<br />";

?>

Me again, here is a last test script that work without changing opcache.optimization_level :

<h1>APC BUG</h1>
<?php
// Expected :
// APC BUG
// This should echo empty string: ><
// This should echo "tutu" string: >tutu<


function table_valeur($table, $cle, $defaut='') {
    foreach (explode('/', $cle) as $k) {

        $table = is_string($table) ? @unserialize($table) : $table;

        if (is_object($table)) {
            $table =  (($k !== "") and isset($table->$k)) ? $table->$k : $defaut;
        } elseif (is_array($table)) {
            $table = isset($table[$k]) ? $table[$k] : $defaut;
        } else {
            $table = $defaut;
        }
    }
    return $table;
}

function vide($texte){
    return "";
}

echo "This should echo empty string: &gt;".vide($Pile['vars'][$zzz=(string)'toto'] = 'tutu')."&lt;<br />";
echo "This should echo \"tutu\" string: &gt;".table_valeur($Pile['vars'],'toto')."&lt;<br />";

?>

hmm, I run this with opcache enable, and fully optimizer. 

seems the output is expected?

"
$ php55 -d opcache.enable=1 -d opcache.optimization_level=0xffffffff /tmp/1.php
This should echo empty string:
This should echo "tutu" string: tutu
"

Please try using this snapshot:

  http://snaps.php.net/php5.5-latest.tar.gz
 
For Windows:

  http://windows.php.net/snapshots/

please try with the latest snapshot of php5.5 in git

Hello Laruence,

I've tried with php-cli (windows and ubuntu), the output is ok.

Antoher try with : Apache/2.4.6 (Ubuntu) + PHP Version 5.5.4-1+debphp.org~raring+1 and the output is not ok.

Can you please try the script with http server ?

that doesn't make sense, are you sure they are the same PHP?

Hi Laruence, i'm pretty sure that Guy use the same php script cause i've sended it to him ;)

@laruence
what makes sense is to use the right flag for cli runtime : opcache.enable is for non-cli PHP whereas opcache.enable_cli is for cli version.

Just try with the good option in order to see the bug :

$ php55 -d opcache.enable_cli=1 -d opcache.optimization_level=0xffffffff /tmp/1.php

Using the right flag to enable opcache with php-cli, the output is also incorrect. I tried with php 5.5.3, 5.5.4 and the latest snapshot.

thank you for your help Cedric

sorry, I used wrong branch of opcache. and now I can reproduce that.

I have got a fix:

$ git diff
diff --git a/ext/opcache/Optimizer/pass1_5.c b/ext/opcache/Optimizer/pass1_5.c
index 795b954..9ef7d8a 100644
--- a/ext/opcache/Optimizer/pass1_5.c
+++ b/ext/opcache/Optimizer/pass1_5.c
@@ -157,8 +157,8 @@ if (ZEND_OPTIMIZER_PASS_1 & OPTIMIZATION_LEVEL) {
 			if (ZEND_OP1_TYPE(opline) == IS_CONST &&
 				opline->extended_value != IS_ARRAY &&
 				opline->extended_value != IS_OBJECT &&
-				opline->extended_value != IS_RESOURCE) {
-				/* cast of constant operand */
+				opline->extended_value != IS_RESOURCE &&
+				Z_TYPE(ZEND_OP1_LITERAL(opline)) != opline->extended_value) {
 				zval res;
 				res = ZEND_OP1_LITERAL(opline);
 				zval_copy_ctor(&res);


to Dmitry:  this is because precalculted hash is lost while doing a nop cast...

could you please review it?

more simple reproduce script:

<?php
function table_valeur($table) {
    return $table['toto'];
}

$Pile['vars'][(string)'toto'] = 'tutu';
var_dump(table_valeur($Pile['vars']));

The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.

Thanks for the patch laruence and dmitry :)