|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
[2010-12-06 22:58 UTC] alan at akbkhome dot com
[2010-12-07 08:30 UTC] dan at velsoft dot com
[2011-05-31 22:37 UTC] alan at akbkhome dot com
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Sun Nov 02 18:00:01 2025 UTC |
Description: ------------ svn_mkdir should return TRUE on successful creation of directory, or FALSE otherwise. However, svn_mkdir assumes that the mkdir will be done on a URL as opposed to a working copy. The "info" struct (svn_commit_info_t **) does not get set if the mkdir is done on a working copy, as it does not commit the changes immediately, but rather adds the changes to be commited (via. svn_client_add in the SVN client lib) The patch below resolves the issue of not returning a boolean, but another patch might be required in the case of committing to a URL. Reproduce code: --------------- if(!svn_mkdir("/some/working/copy/path")) { echo "Could not create directory"; } Patch to remove assumption of commit and URL instead of working copy at http://pastebin.ca/2011999 Expected result: ---------------- FALSE if the directory exists, or the mkdir fails for another reason. TRUE if the directory is successfully created. Actual result: -------------- svn_mkdir always returns FALSE if the svn_mkdir is on a working copy directory.