php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #54500 remove bogus ltdl linking
Submitted: 2011-04-09 16:28 UTC Modified: 2017-01-10 11:01 UTC
From: glen at delfi dot ee Assigned: leigh (profile)
Status: Closed Package: mcrypt related
PHP Version: 5.3.6 OS: PLD Linux
Private report: No CVE-ID: None
View Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
If you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: glen at delfi dot ee
New email:
PHP Version: OS:

 

 [2011-04-09 16:28 UTC] glen at delfi dot ee 
Description:
------------
seems mcrypt adds bogus ltdl lib to linking.

this php extension does not use ltdl, it uses mcrypt_module_open from mcrypt 
library, and mcrypt library links with ltdl, the -lltld in php extension is 
clearly superfluous


the original commit from 2003:
http://svn.php.net/viewvc?view=revision&revision=114195

the author there either had no clue what he was doing or the mcrypt he used for 
linking was broken, as even that time the php extension used no symbols from 
libtool's ltdl library

the patch removes ltdl linking

Patches

mcrypt-libs.patch (last revision 2011-04-09 14:29 UTC by glen at delfi dot ee)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-04-09 16:35 UTC] glen at delfi dot ee 
seems the original place the -lltdl snipped in is here:

http://svn.php.net/viewvc?view=revision&revision=30132

if that's any help for accepting patch
 [2011-05-29 18:50 UTC] felipe@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: derick
 [2017-01-10 11:01 UTC] leigh@php.net
-Status: Assigned +Status: Closed -Assigned To: derick +Assigned To: leigh
 [2017-01-10 11:01 UTC] leigh@php.net 
Fixed in master
 [2017-07-25 06:40 UTC] php-bugs-2017 at ryandesign dot com 
Can you show me the commit where you think it was fixed? It doesn't look fixed to me, but maybe I'm looking in the wrong place.

For PHP 7.2 the mcrypt extension was moved to PECL, but even there the relevant lines haven't been touched since 2006.

https://github.com/php/pecl-encryption-mcrypt/blob/master/config.m4

Or perhaps you're saying you "fixed" it by moving it to PECL thus making it someone else's problem.

https://github.com/php/php-src/commit/1da589eeaeb9bcb4befac4a72c6659e320ddc9bb
 [2019-12-21 17:24 UTC] php-bugs-2017 at ryandesign dot com 
Could you clarify, please?
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Mon Dec 23 00:01:29 2024 UTC