php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #51434 Memcache::increment has badly written description
Submitted: 2010-03-30 04:50 UTC Modified: 2010-03-31 01:47 UTC
From: dominics at gmail dot com Assigned: markskilbeck (profile)
Status: Closed Package: Documentation problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
If you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: dominics at gmail dot com
New email:
PHP Version: OS:

 

 [2010-03-30 04:50 UTC] dominics at gmail dot com
Description:
------------
http://php.net/manual/en/function.memcache-increment.php

The description of Memcache::increment() is confusing. It is missing determiners, uses incorrect prepositions and apostrophes, and has tense disagreement.

Existing: Memcache::increment() increments value of the item on the specified _value_.
Suggestion: Memcache::increment() increments the value of an item by the specified _value_.

Existing: If the item with _key_ was not numeric and cannot be converted to number, it will change it's value to value.
Suggestion: If the item specified by _key_ is not numeric and cannot be converted to a number, Memcache::increment() will change its value to _value_.

Existing: Memcache::increment() does not create an item if it didn't exist.
Suggestion: Memcache::increment() does not create an item if one doesn't already exist.

Existing: Note: Do not use Memcache::increment() with item, which was stored compressed, because consequent call to Memcache::get() will fail.
Suggestion: Note: Do not use Memcache::increment() with items that have been stored compressed because subsequent calls to Memcache::get() will fail.

Expected result:
----------------
Memcache::increment() increments the value of an item by the specified _value_. If the item specified by _key_ is not numeric and cannot be converted to a number, Memcache::increment() will change its value to _value_. Memcache::increment() does not create an item if one doesn't already exist.

   Note: Do not use Memcache::increment() with items that have been stored compressed because subsequent calls to Memcache::get() will fail.

Actual result:
--------------
Memcache::increment() increments value of the item on the specified _value_. If the item with _key_ was not numeric and cannot be converted to number, it will change it's value to value. Memcache::increment() does not create an item if it didn't exist.

   Note: Do not use Memcache::increment() with item, which was stored compressed, because consequent call to Memcache::get() will fail.


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-03-31 01:04 UTC] markskilbeck@php.net
Automatic comment from SVN on behalf of markskilbeck
Revision: http://svn.php.net/viewvc/?view=revision&revision=297209
Log: Closes bug #51434
 [2010-03-31 01:47 UTC] markskilbeck@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: markskilbeck
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved.
Last updated: Sun Jun 01 01:01:27 2025 UTC