php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #51379 windows.php.net styling.
Submitted: 2010-03-24 10:46 UTC Modified: 2010-12-20 12:53 UTC
From: rquadling@php.net Assigned: kalle (profile)
Status: Closed Package: Website problem
PHP Version: Irrelevant OS: N/A
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: rquadling@php.net
New email:
PHP Version: OS:

 

 [2010-03-24 10:46 UTC] rquadling@php.net 
Description:
------------
The styling of the left hand column for the downloads, qa and snapshots pages is inconsistent.

The cause is that the left-column content is not inside the content-column container.

Patch file supplied to tidy this up. Also a minor change to the team page too (missing an <p></p> pairing).

Patches

tidylistings (last revision 2010-03-24 09:47 UTC by rquadling@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-03-24 10:47 UTC] rquadling@php.net 
The following patch has been added/updated:

Patch Name: tidylistings
Revision:   1269424053
URL:        http://bugs.php.net/patch-display.php?bug=51379&patch=tidylistings&revision=1269424053
 [2010-03-24 21:34 UTC] bjori@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: kalle
 [2010-03-24 21:34 UTC] bjori@php.net 
I don't see how that team.php patch changes anything.
In fact, all it does is to replace one tab with 7 spaces.

And I see no change in news_line.php whatsoever.

Why do you need to check both $mode and SCRIPT_FILENAME in left_column.php?

(I btw have no windows karma, so assigning this to someone I believe has)
 [2010-03-25 04:43 UTC] kalle@php.net 
Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&amp;revision=296770
Log: Fixed bug #51379 (windows.php.net styling) - Patch by rquadling@
 [2010-03-25 04:43 UTC] kalle@php.net
-Status: Assigned +Status: Closed
 [2010-03-25 04:43 UTC] kalle@php.net 
This bug has been fixed in SVN. Since the websites are not directly
updated from the SVN server, the fix might need some time to spread
across the globe to all mirror sites, including PHP.net itself.

Thank you for the report, and for helping us make PHP.net better.
 [2010-03-25 09:29 UTC] rquadling@php.net 
Hannes, the whitespace was a mistake. I was looking in the wrong place.

The $mode & SCRIPT_FILENAME check is for consistency against the other code which 
does the same tests.
 [2010-12-20 12:53 UTC] jani@php.net
-Package: Tidy +Package: Website problem
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu May 23 23:01:32 2024 UTC