|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2010-01-02 15:03 UTC] stein at rhrk dot uni-kl dot de
Description: ------------ MySQLi_Result::fetch_object sets properties before calling the constructor, see BUG #49521 The behavior is similar to the one in BUG #49521 which has been fixed as of PHP 5.2.12. Note: It should be considered that this behavior may be not bug at all. Calling the constructor BEFORE setting the properties (as done in BUG #49521) leaves no possibility to work with the data at "construction time" of the object. Setting default properties could be done by assigning them in the class-definition, but setting other properties depending on the loaded data is hard to do, when this data is not yet available when the constructor is called. This problem is even harder to solve, as no setters for the properties are called, even if they are declared as private. Reproduce code: --------------- class Test { private $myprivate = 0; function __construct() { echo 'constructor called, $myprivate is ', $this->myprivate; } function __set ( $name, $value ) { echo 'setting ', $name, ' to ', $value; $this->{$name} = (int) $value; } } $mysqli->query('SELECT 1 AS myprivate, 2 AS mypublic')->fetch_object('Test'); Expected result: ---------------- If the same way to handle this bug as in BUG #49521 is considered: constructor called, $myprivate is 0 setting mypublic to 2 object(Test)#6 (2) { ["myprivate:private"]=> string(1) "1" ["mypublic"]=> int(2) } But maybe the following behavior would make more sense if it should be changed: constructor called, $myprivate is 0 setting myprivate to 1 setting mypublic to 2 object(Test)#6 (2) { ["myprivate:private"]=> int(1) ["mypublic"]=> int(2) } Actual result: -------------- setting mypublic to 2 constructor called, $myprivate is 1 object(Test)#6 (2) { ["myprivate:private"]=> string(1) "1" ["mypublic"]=> int(2) } PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Fri Oct 24 13:00:02 2025 UTC |
I do not think this is behavior is wrong. If the vars where protected the __set and __get functions where called even if no constructor is called. I think you can implement read only properties with this behavior Check this example. You will see that when fetch_object is called all properties are setted. After the fetch_object call that property will be read only. class Test { protected $_init=false; protected $_field1=null; protected $_meta=array('_field1'=>1); public function __construct(){ $this->_init=true; } public function __set ($name, $value) { if($this->_init && $this->_meta[$name]){ throw new Exception('read only'); } $this->$name=$value; } }