|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2008-10-12 14:03 UTC] mattias dot geniar at gmail dot com
Description:
------------
Creating a dBase file with a DATE-field type, will corrupt the database. Work-around as for now is to use a CHAR-type and convert it later manually.
This bug is similar to #42261, which dates back to August 2007.
Reproduce code:
---------------
<?php
// database "definition"
$def = array(
array("date", "D"),
array("name", "C", 50),
array("email", "C", 128),
array("ismember", "L")
);
// creation
if (!dbase_create('test.dbf', $def)) {
echo "Error, can't create the database\n";
}
// open in read-write mode
$db = dbase_open('test.dbf', 2);
if ($db) {
for ($i = 0; $i < 5; $i++) {
dbase_add_record($db, array(
date('Ymd'),
'Name #'. $i,
'Email #'. $i,
'T'));
}
dbase_close($db);
}
?>
Expected result:
----------------
A simple database with 5 lines, where DATE, Name & Email are entered correctly.
Actual result:
--------------
The code above will create file called "test.dbf", which is corrupted when opening it with any normal DBF-viewer (CDBF, DBF Manager, ...). If the DATE-field is replaced with a CHAR-field, all works fine. Date-format is taken from the PHP.NET website and confirmed by the dBase-format.
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Thu Nov 21 10:01:29 2024 UTC |
The problem is that a record of type D (date) as well as type L (logical) get's into the database with the length of 0 and not 8 (or 1 in the case of L). I traced down this bug to the put_dbf_field() function in dbf_head.c In there the record is written to disk, but in neither of the D and L types the length of the field is put in the correct struct. The fix is to remove both the cases for D and L so the length is set using the default case. Was: 196 switch (dbf->db_type) { 197 case 'N': 198 dbfield.dbf_flen[0] = dbf->db_flen; 199 dbfield.dbf_flen[1] = dbf->db_fdc; 200 break; 201 case 'D': 202 dbf->db_flen = 8; 203 break; 204 case 'L': 205 dbf->db_flen = 1; 206 break; 207 default: 208 put_short(dbfield.dbf_flen, dbf->db_flen); Is: 196 switch (dbf->db_type) { 197 case 'N': 198 dbfield.dbf_flen[0] = dbf->db_flen; 199 dbfield.dbf_flen[1] = dbf->db_fdc; 200 break; 201 default: 202 put_short(dbfield.dbf_flen, dbf->db_flen); 203 } I am aware this is not the way to submit fixes but I'm limited by time and still wanted to share the knowledge I did proceed using comments to specify this. Hopefully someone with an CVS account can use this info to get the change into the repository.