php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Doc Bug #31677 Document ibase changes in PHP 5
Submitted: 2005-01-24 10:11 UTC Modified: 2005-04-29 16:35 UTC
From: 3tantes at inbox dot lv Assigned:
Status: Not a bug Package: Documentation problem
PHP Version: 5.0.1 OS: ANY
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: 3tantes at inbox dot lv
New email:
PHP Version: OS:

 

 [2005-01-24 10:11 UTC] 3tantes at inbox dot lv
Description:
------------
PLEASE note in documentation that ibase functions now use services:
* ibase_add_user
* ibase_modify_user
(maybe some other functions too, i haven't used others)

it may cause some problems, when upgrading from php4 to php5!


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2005-02-24 17:11 UTC] philip@php.net
Could you please explain what this means, and how/what ibase documentation should be changed?
 [2005-03-05 01:00 UTC] phpdoc at lists dot php dot net
No feedback was provided for this bug for over a week, so it is
being suspended automatically. If you are able to provide the
information that was originally requested, please do so and change
the status of the bug back to "Open".
 [2005-03-05 01:16 UTC] 3tantes at inbox dot lv
bool ibase_add_user ( resource service_handle, string user_name, string password [, string first_name [, string middle_name [, string last_name]]] )

i'm talking about the first paramater service_handle of function. in earler versions it wasn't there. this may cause problems on upgrade, cause this change is not backward-compatible.

is there any section, where php programmers can see the dangerous areas, that must be changed when upgrading? it would be nice if there'd be in documentation of ibase_add_user, ibase_modify_user etc a note/warning, that this function has changed in php5 and that these changes are not backward compatible.
 [2005-03-05 03:09 UTC] philip@php.net
I don't notice a code difference but AFAICT in PHP 5 the following happened:

* interbase.c was split up into multiple files
* Using ibase_add_user() as an example, the following code remains the same:

PHP_FUNCTION(ibase_add_user)
{
_php_ibase_user(INTERNAL_FUNCTION_PARAM_PASSTHRU, isc_action_svc_add_user);
}

* but the paramaters apparently changed, here's the proto definition in the source:

PHP 4:
/* {{{ proto bool ibase_add_user(string server, string dba_user_name, string dba _password, string user_name, string password [, string first_name [, string middle_name [, string last_name]]]) Add an user to security database (only for IB6 or later) */

PHP 5:
/* {{{ proto bool ibase_add_user(resource service_handle, string user_name, string password [, string first_name [, string middle_name [, string last_name]]]) Add a user to security database */

Someone who knows ibase, and/or can confidently understand php-src, should add appropriate CHANGELOG entries to the appropriate ibase docs rather than depend only the on prototype comments.

I assume service_handle comes from ibase_connect(), right?
 [2005-04-29 16:35 UTC] vrana@php.net
It had been documented at 2004/11/04 - before this bug was created.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sun Jul 07 10:01:31 2024 UTC