|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2003-05-18 21:38 UTC] info at rhalff dot com
Reproduction of this bug:
1. Create the two files below:
-------------------------
php_snippet.ini:
[PHP]
extension = bcmath.so
extension = bz2.so
extension = calendar.so
extension = cdpf.so
extension = crack.so
extension = curl.so
-------------------------
<?php
require_once('Config.php');
$datasrc = 'php_snippet.ini';
$phpIni = new Config();
$root =& $phpIni->parseConfig($datasrc, 'inicommented');
if (PEAR::isError($root)) {
die($root->getMessage());
}
print_r($root->toArray());
?>
------------------------
2. Run test.php
The result will be:
Fatal error: [] operator not supported for strings in /usr/lib/php/Config/Container.php on line 658
Solution:
Original Code:
650: foreach ($newArr as $key => $value) {
651: if (isset($array[$this->name][$key])) {
652: // duplicate name/type
653: if (!isset($array[$this->name][$key][0])) {
654: $old = $array[$this->name][$key];
655: unset($array[$this->name][$key]);
656: $array[$this->name][$key][0] = $old;
657: }
658: $array[$this->name][$key][] = $value;
659: } elseif (isset($array[$this->name][$key][0])) {
660: $array[$this->name][$key][] = $value;
661: } else {
662: $array[$this->name][$key] = $value;
663: }
664: }
Fixed Code:
650: foreach ($newArr as $key => $value) {
651: if (isset($array[$this->name][$key])) {
652: // duplicate name/type
if(!is_array($array[$this->name][$key])) {
$old = $array[$this->name][$key];
unset($array[$this->name][$key]);
$array[$this->name][$key][0] = $old;
} else {
$array[$this->name][$key][] = $value;
}
661: } else {
662: $array[$this->name][$key] = $value;
663: }
664: }
Explaination:
The original code checks if $array[$this->name][$key][0] is set
and falsly assumes that if [0] exists it will be an array.
In the example first it will set $array['PHP']['extension'] = bcmath.so
The second time around it will detect that $array['PHP']['extension'] allready exists.
But $array['PHP']['extension'][0] will be 'b' as
$array['PHP']['extension'][1] will be 'c' and
$array['PHP']['extension'][2] will be 'm' and
$array['PHP']['extension'][3] will be 'a' and
$array['PHP']['extension'][4] will be 't' and
$array['PHP']['extension'][5] will be 'h' etc..
So when the code reaches $array[$this->name][$key][] = $value;
$array[$this->name][$key] will still be a string and this explains the error message.
That's why the check should be like:
!is_array($array[$this->name][$key])
The rest of the changes in the Fixed code should be obvious.
Greetings,
Rob Halff
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Mon Oct 27 06:00:01 2025 UTC |
Somewhat more readable code: Solution: Original Code: 650: foreach ($newArr as $key => $value) { 651: if (isset($array[$this->name][$key])) { 652: // duplicate name/type 653: if (!isset($array[$this->name][$key][0])) { 654: $old = $array[$this->name][$key]; 655: unset($array[$this->name][$key]); 656: $array[$this->name][$key][0] = $old; 657: } 658: $array[$this->name][$key][] = $value; 659: } elseif (isset($array[$this->name][$key][0])) { 660: $array[$this->name][$key][] = $value; 661: } else { 662: $array[$this->name][$key] = $value; 663: } 664: } Fixed Code: 650: foreach ($newArr as $key => $value) { 651: if (isset($array[$this->name][$key])) { 652: // duplicate name/type if(!is_array($array[$this->name][$key])) { $old = $array[$this->name][$key]; unset($array[$this->name][$key]); $array[$this->name][$key][0] = $old; } else { $array[$this->name][$key][] = $value; } 661: } else { 662: $array[$this->name][$key] = $value; 663: } 664: }Hi Rob, The problem with your solution is that it breaks this: require_once('Config.php'); $array['a']['b'][0]['foo']="value1"; $array['a']['b'][1]['foo']="value2"; $phpIni = new Config(); $root =& $phpIni->parseConfig($array, 'phparray'); echo '<pre>'; var_dump($root->toArray()); echo '</pre>'; Here is the solution I suggest instead: foreach ($newArr as $key => $value) { if (isset($array[$this->name][$key])) { // duplicate name/type if (!is_array($array[$this->name][$key]) || !isset($array[$this->name][$key][0])) { $old = $array[$this->name][$key]; unset($array[$this->name][$key]); $array[$this->name][$key][0] = $old; } $array[$this->name][$key][] = $value; } elseif (isset($array[$this->name][$key][0])) { $array[$this->name][$key][] = $value; } else { $array[$this->name][$key] = $value; } } Please let me know if this would make it for you. Thanks for the bug report. Bertrand Mansion MamasamHmm your fix will cause: [PHP] extension = bcmath.so extension = bz2.so extension = calendar.so extension = cdpf.so extension = crack.so extension = curl.so Array ( [root] => Array ( [PHP] => Array ( [extension] => curl.so ) ) ) To me it seems the usage of [0] in the code is wrong. Since it can both mean the first character of a string as the first item in an array. For example try: $string = "Hi there"; echo $string[0]; $string[0] = "other value"; echo $string; I think the code should be something like this: 650: foreach ($newArr as $key => $value) { 651: if (isset($array[$this->name][$key])) { 652: // duplicate name/type if(!is_array($array[$this->name][$key])) { $old = $array[$this->name][$key]; unset($array[$this->name][$key]); $array[$this->name][$key][0] = $old; } $array[$this->name][$key][] = $value; 661: } else { 662: $array[$this->name][$key] = $value; 663: } 664: } I was wrong with the else part in my earlier code fix. Im not very sure my fix is good enough, so I will try to find if there is a better sollution.Ok, so that's kind of excpected behaviour then. To me te fix seems to work, there's only one unlogical thing left in there. if (isset($array[$this->name][$key])) { // duplicate name/type ....... } elseif (isset($array[$this->name][$key][0])) { The elseif will never be reached, since isset($array[$this->name][$key]) will always be true first.