|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2018-12-26 18:29 UTC] chealer at gmail dot com
Description: ------------ I noticed tens of issues in PHP documentation over the years. Sometimes, I tried to get them fixed. I opened bug reports, and about 5 times I must have tried to use "Php Docbook Online Editor". Unfortunately, to my knowledge none of my attempts to fix the doc with Php Docbook Online Editor worked. I had such a strong suspicion that the last 2 attempts, I noted what I did to confirm. As reported in http://news.php.net/php.doc/969385815 I submitted a proposal in 2015 for addslashes which was not accepted. It appears that this proposal is completely lost. I cannot even find any evidence that it was made. I reported this to the phpdoc mailing list years ago and did not get any answer: http://news.php.net/php.doc/969385815 Some time later, as I did not trust Php Docbook Online Editor, I submitted issue report #70120: https://bugs.php.net/bug.php?id=70120&edit=2 Unfortunately, the page still has several issues, so I tried to use Php Docbook Online Editor once again to actually solve the issue on 2016-03-26, but that time I took notes. And unfortunately, over 2 years later, my proposal is neither accepted, nor even acknowledged in any way that I can see. I did not receive any email, which is not surprising given that I was not asked for an address. So once again, the Edit button which seems to suggest the documentation is a wiki misled me. I thought I could edit easily, but in fact I put my time in the garbage. I am guessing that Php Docbook Online Editor is not completely broken, so I am not going to suggest dismantlement, but at least one of the following should be done: 1. Make it less likely that contributors reach Php Docbook Online Editor from the documentation. Either remove the link, move it somewhere less prominent, or change the label ("Propose a change / Edit" would already be less misleading). 2. Implement basic features and do minimal quality assurance to confirm that these features work. 3. Add a warning when launching Php Docbook Online Editor that it is experimental, or - better yet - list the main areas known to be broken. Patchespdo-prepare (last revision 2018-12-27 11:32 UTC by cmb@php.net)Pull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Fri Oct 24 07:00:01 2025 UTC |
I suppose these patches have not been swallowed by PhDOE, but rather have been rejected, maybe because they have gone stale (PdDOE apparently doesn't store diffs, but rather the complete file, so if someone else edits the file, the presented patch often makes no sense anymore). Also, we likely delete unsuitable patches without any notice to submitters, since often it is not possible to notify them. > Make it less likely that contributors reach Php Docbook Online > Editor from the documentation. Either remove the link, move it > somewhere less prominent, or change the label ("Propose a change / > Edit" would already be less misleading). I think that we should remove the link altogether. A considerable percentage of submitted patches are done by trolls who try to make malicious or at least obviously bad changes. It's rather annoying to check and delete these patches (if the latter is even allowed). In the (hopefully not too) long run we should really switch to Git[1] to be able to replace PhDOE with Github pull requests. > After I submitted a proposal for prepare(), the Patches for > review tab indicated "(0)". Yet, it contained stuff from more than > 20 people. Indeed, the count appears to be broken. However, I can't find your patch regarding PDO::prepare, and there are currently only submitted patches from eight people for the *English* language. [1] <http://news.php.net/php.doc/969386622>