php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #66847 svn.php.net style sheets useless for viewing source code
Submitted: 2014-03-07 15:41 UTC Modified: 2014-12-27 19:23 UTC
Votes:1
Avg. Score:3.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: kentfredric at gmail dot com Assigned: sobak (profile)
Status: Closed Package: Website problem
PHP Version: Irrelevant OS: N/A
Private report: No CVE-ID: None
 [2014-03-07 15:41 UTC] kentfredric at gmail dot com
Description:
------------
I was just looking in to see the source of a PEAR module hosted on svn.php.net,
to see how it was implemented:

http://svn.php.net/viewvc/pear/packages/Var_Dump/trunk/Var_Dump.php?revision=237750&view=markup

To my horror, I noticed that:

1. The source code is horribly garish in terms of colouring, here, no colour at all would be preferred to the intermittent low-contrast purple banding.

2. The source code lacks CSS bits to preserve indentation, further decreasing legibility.

The CSS Part is easy enough to resolve: 


white-space: pre-wrap

And it would be good to have the lines in monospaced text:

font-family: monospaced

And it should be safe to stick that in `div#vc_file > table` 's style rule.


An alternative would be simply un-blocking the ability to view source files raw in VC

For instance, gentoo's install of VC allows you to view source, by clicking a "Download" on each source file, giving 

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-perl/Algorithm-C3/Algorithm-C3-0.80.0.ebuild?revision=1.1

Which is quite legible.

However .... svn.php.net seems to have explicitly blocked this function for some reason:

http://svn.php.net/viewvc/pear/packages/Var_Dump/trunk/Var_Dump.php?revision=237750 

-> 
---
Checkout view is disabled
HTTP Response Status

403 Forbidden
---


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-03-23 16:07 UTC] sobak@php.net
-Status: Open +Status: Verified -Assigned To: +Assigned To: sobak
 [2014-03-23 16:07 UTC] sobak@php.net
Hi,

I've pushed commit which improves code listings on svn.php.net. Now it should be more way more readable, even without highlighting.

"An alternative would be simply un-blocking the ability to view source files raw in VC"
I have no abbility to do this but I will talk to competent people.

Thanks for your report.
 [2014-12-27 19:23 UTC] sobak@php.net
-Status: Verified +Status: Closed
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Mar 28 15:01:29 2024 UTC