php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #64396 tests/basic/req60524.phpt should not be run on Windows
Submitted: 2013-03-08 23:42 UTC Modified: 2013-09-03 16:42 UTC
From: mattficken@php.net Assigned: mattficken (profile)
Status: Closed Package: *Directory/Filesystem functions
PHP Version: 5.5.0alpha5 OS: Windows
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2013-03-08 23:42 UTC] mattficken@php.net 
Description:
------------
This is a new test of sys_get_temp_dir() but won't work on Windows.

I have attached a patch that patches this test and creates a win32 equivalent test.


Expected result:
----------------
/path/to/temp/dir

Actual result:
--------------
C:\Users\matt\AppData\Local\Temp

Patches

req60524.patch (last revision 2013-03-08 23:42 UTC by mattficken)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-03-09 01:07 UTC] pajoye@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: mattficken
 [2013-03-09 01:07 UTC] pajoye@php.net 
Thanks for the patch!

I would modify the test to compare the string result instead and output OK when it 
matches. Doing so will avoid to create a windows only version of this test (which 
basically test the ini setting). Feel free to commit it once you are done :)
 [2013-03-21 22:55 UTC] mattficken@php.net 
The point of this test is to test the new sys_temp_dir directive to make sure that the directive value is returned by sys_get_temp_dir.    The point of the directive is to enable using different INI files to get sys_get_temp_dir to return different temp dirs (for virtual hosts).

Directives have to be set in the INI section. The PHPT format doesn't provide a way to have different INI sections for Windows or *nix.

Therefore there needs to be a separate -win32 fork for this test, which is what the original patch does.
 [2013-03-22 06:30 UTC] pajoye@php.net 
Please duplicate the test and commit it :)
 [2013-09-01 01:16 UTC] pajoye@php.net 
Matt? Did you apply it?
 [2013-09-03 16:42 UTC] mattficken@php.net 
Yes I committed it, but forgot to close this bug report.
 [2013-09-03 16:42 UTC] mattficken@php.net
-Status: Feedback +Status: Closed
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 19 16:01:27 2024 UTC