php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
Submitted: 2012-04-03 16:31 UTC Modified: 2012-04-10 10:28 UTC
From: ab@php.net Assigned: ab (profile)
Status: Closed Package: Date/time related
PHP Version: 5.3.10 OS: Windows
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2012-04-03 16:31 UTC] ab@php.net 
Description:
------------
Current test diff

01+ Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone
setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Paris' for '2.0/DST' instead in C:\php-sdk\php53\vc9\x86\php-src\ext\date\tests\date_default_timezone_get-1.php on line 3
002+ Europe/Paris
001- Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone
setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'UTC' for 'UTC/0.0/no DST' instead in %sdate_default_timezone_get-1.php on line 3
002- UTC
004+ Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Paris' for '2.0/DST' instead in C:\php-sdk\php53\vc9\x86\php-src\ext\date\tests\date_default_timezone_get-1.php on line 4
005+ Europe/Paris
004- Warning: date(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'UTC' for 'UTC/0.0/no DST' instead in %sdate_default_timezone_get-1.php on line 4
005- UTC

Expected result:
----------------
test pass

Actual result:
--------------
test fail

Patches

bug61610-2.diff.patch.txt (last revision 2012-04-10 01:55 UTC by mattficken@php.net)
61610.diff (last revision 2012-04-03 17:59 UTC by ab@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-04-03 17:59 UTC] ab@php.net 
The following patch has been added/updated:

Patch Name: 61610.diff
Revision:   1333475950
URL:        https://bugs.php.net/patch-display.php?bug=61610&patch=61610.diff&revision=1333475950
 [2012-04-03 18:01 UTC] ab@php.net 
The behaviour on windows is to select an arbitrary timezone from the current system settings. This gives no chance to hardcode the timezone name, for instance for UTC+1 it could choose from the multiple names like Europe/Berlin or Europe/Paris . For this reason the test is parametrized so there is no hardcoded timezone data.

The original test made to be skipped on windows and a duplicate was made for windows.
 [2012-04-03 18:13 UTC] ab@php.net 
Tested on debian and win7 both x86.
 [2012-04-10 01:55 UTC] mattficken@php.net 
The following patch has been added/updated:

Patch Name: bug61610-2.diff.patch.txt
Revision:   1334022955
URL:        https://bugs.php.net/patch-display.php?bug=61610&patch=bug61610-2.diff.patch.txt&revision=1334022955
 [2012-04-10 01:56 UTC] mattficken@php.net 
There is a slight typo on the first patch(date_default_timezone_get-2 instead of date_default_timezone_get-1).

The second patch fixes it
 [2012-04-10 01:58 UTC] mattficken@php.net 
The second patch passes on Windows 7 and Gentoo Linux (x86 & x64) on php-5-3-r0f180a6.
 [2012-04-10 10:25 UTC] ab@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d89b65f98503bbe99ee7810a97b2c0a16da2651c
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2012-04-10 10:25 UTC] ab@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=fbbad87056328b30d2b398cb78c3cf625f453e52
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2012-04-10 10:25 UTC] ab@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=aa6ad6bc095d3d490c1808e1ff327da051898cd3
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2012-04-10 10:28 UTC] ab@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.
 [2012-04-10 10:28 UTC] ab@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: ab
 [2012-04-10 10:39 UTC] ab@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d89b65f98503bbe99ee7810a97b2c0a16da2651c
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2012-04-10 10:39 UTC] ab@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=fbbad87056328b30d2b398cb78c3cf625f453e52
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2012-04-18 09:45 UTC] laruence@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=aa6ad6bc095d3d490c1808e1ff327da051898cd3
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2012-07-24 23:36 UTC] rasmus@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=aa6ad6bc095d3d490c1808e1ff327da051898cd3
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2013-11-17 09:32 UTC] laruence@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=aa6ad6bc095d3d490c1808e1ff327da051898cd3
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2014-10-07 23:27 UTC] stas@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=fbbad87056328b30d2b398cb78c3cf625f453e52
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2014-10-07 23:27 UTC] stas@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=d89b65f98503bbe99ee7810a97b2c0a16da2651c
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2014-10-07 23:38 UTC] stas@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=fbbad87056328b30d2b398cb78c3cf625f453e52
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 [2014-10-07 23:38 UTC] stas@php.net 
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=d89b65f98503bbe99ee7810a97b2c0a16da2651c
Log: Fixed bug #61610 Test ext\date\tests\date_default_timezone_get-1.diff fails
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 26 17:01:30 2024 UTC