error msg :

Warning: copy(): Unable to access http://www.xxxxx.com/testcopy/nok.jpg in /............/test.php

The following patch restores part of behaviour from 5.2.6 yet has an extra check to see if the URL contains "../" which is where the removal came from. It is not a 100% correct "fix" in that it still allows for unknown URL vectors to bypass safe_mode, however, it is less broken this way for us. Perhaps the patch will help someone else.

Remember, this is a safe_mode bypass issue that was fixed and the underlying cause (URLs: http: mapping to a local file incorrectly) looks to me unfixed. To me it looks as if safe_mode fails in this case but it also do no "extra" harm that won't be allowed with safe_mode disabled. Have I missed something?

diff -Nur php-5.2.8/main/safe_mode.c php-5.2.8_1/main/safe_mode.c
--- php-5.2.8/main/safe_mode.c	2008-07-24 18:01:59.000000000 +0200
+++ php-5.2.8_1/main/safe_mode.c	2008-12-17 15:01:07.502862702 +0100
@@ -52,6 +52,7 @@
 	long uid=0L, gid=0L, duid=0L, dgid=0L;
 	char path[MAXPATHLEN];
 	char *s, filenamecopy[MAXPATHLEN];
+	php_stream_wrapper *wrapper = NULL;
 	TSRMLS_FETCH();
 
 	path[0] = '\0';
@@ -72,6 +73,15 @@
 			mode = CHECKUID_CHECK_FILE_AND_DIR;
 		}
 	}
+
+	/* 
+	 * If given filepath is a URL, allow - safe mode stuff
+	 * related to URL's is checked in individual functions
+        * Possibly/likely allows for safe_mode bypass!!!
+	 */
+	wrapper = php_stream_locate_url_wrapper(filename, NULL, STREAM_LOCATE_WRAPPERS_ONLY TSRMLS_CC);
+	if ((wrapper != NULL) && (strstr(filename, "..\/") == NULL))
+		return 1;
 		
 	/* First we see if the file is owned by the same user...
 	 * If that fails, passthrough and check directory...

thanks : this workaround works fine !

problem still in 5.2.9

Hello, I've the same problem but I don't understand how use this patch. Actually safe_mode off but it's not a solution.

How and Where Am i use this :
---------------
diff -Nur php-5.2.8/main/safe_mode.c php-5.2.8_1/main/safe_mode.c
--- php-5.2.8/main/safe_mode.c	2008-07-24 18:01:59.000000000 +0200
+++ php-5.2.8_1/main/safe_mode.c	2008-12-17 15:01:07.502862702 +0100
@@ -52,6 +52,7 @@
 	long uid=0L, gid=0L, duid=0L, dgid=0L;
 	char path[MAXPATHLEN];
 	char *s, filenamecopy[MAXPATHLEN];
+	php_stream_wrapper *wrapper = NULL;
 	TSRMLS_FETCH();
 
 	path[0] = '\0';
@@ -72,6 +73,15 @@
 			mode = CHECKUID_CHECK_FILE_AND_DIR;
 		}
 	}
+
+	/* 
+	 * If given filepath is a URL, allow - safe mode stuff
+	 * related to URL's is checked in individual functions
+        * Possibly/likely allows for safe_mode bypass!!!
+	 */
+	wrapper = php_stream_locate_url_wrapper(filename, NULL,
STREAM_LOCATE_WRAPPERS_ONLY TSRMLS_CC);
+	if ((wrapper != NULL) && (strstr(filename, "..\/") == NULL))
+		return 1;
 		
 	/* First we see if the file is owned by the same user...
 	 * If that fails, passthrough and check directory...
---------------

Thx

You apply the patch using the command patch when you build PHP from the sourcecode. If you've never done this before I cannot recommend that you do this for something like PHP.

If you still go ahead, download the PHP sourcecode, extract it and read the files (README and INSTALL). Check documentation for using the patch command (man patch). in general you save the patch to a file (lets call it safemode.patch) then you simply run "patch main/safe_mode.c < safemode.patch" in the folder where you unpacked the source

Could reproduce. With safe mode, files which are handled by stream wrappers are checked against the filesystem. This is wrong.

same on centos 5.5 php 5.2.17

Same here on php 5.2.17, Linux blue 2.6.37-fw2.

I can reproduce this issue on PHP 5.3.13

As of PHP 5.4.0 the safe mode "feature" has been removed, so this
ticket can be closed.