| Bug #46759 | magic_quotes_gpc doesn't work | ||||
|---|---|---|---|---|---|
| Submitted: | 5 Dec 2008 11:52am UTC | Modified: | 6 Dec 2008 5:54pm UTC | ||
| From: | vrana@php.net | Assigned to: | |||
| Status: | Closed | Category: | Variables related | ||
| Version: | 5.2.7 | OS: | Windows | ||
| Votes: | 4 | Avg. Score: | 4.8 ± 0.4 | Reproduced: | 4 of 4 (100.0%) |
| Same Version: | 4 (100.0%) | Same OS: | 1 (25.0%) | ||
[5 Dec 2008 11:52am UTC] vrana@php.net
[6 Dec 2008 1:28am UTC] brion at pobox dot com
This causes downstream MediaWiki bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=16570 Data corruption and failure to properly submit edits when magic_quotes_gpc is enabled. (Workaround: disable magic_quotes_gpc so input doesn't get munged by stripslashes().) Presumably causes similar breakage in every other web app that attempts to correct for magic_quotes_gpc.
[6 Dec 2008 10:03am UTC] cabel at panic dot com
We haven't yet had a chance to addslashes() our input in preparation for PHP 6. So as it stands, this bug -- which we're also seeing with 5.2.7 -- currently means giant scary security holes in our scripts as we were relying on magic_quotes_gpc to make things "safe". Not great...
[6 Dec 2008 4:20pm UTC] magicaltux@php.net
Fix for bug #42718 seems at the origin of this bug. If the fix is reverted, magic_quotes_gpc works again as expected.
[6 Dec 2008 5:08pm UTC] magicaltux@php.net
After checking bug #42718 and filter extension's documentation, I believe enabling a filter *should not* disable magic_quotes_gpc (nothing is written in the documentation about this). This patch allows application of magic_quotes_gpc *after* filters execution *if* enabled. http://ookoo.org/svn/snip/php_5_2-broken_filter_and_magic_quotes.patch
[6 Dec 2008 5:26pm UTC] scottmac@php.net
This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. I've backed out the fix for bug #42718
[6 Dec 2008 5:54pm UTC] lbarnaud@php.net
A quick workaround for 5.2.7 users is to add the following in the php.ini: filter.default_flags=0
