| Bug #44135 | PDO MySQL does not support CLIENT_FOUND_ROWS | ||||
|---|---|---|---|---|---|
| Submitted: | 16 Feb 2008 3:26am UTC | Modified: | 2 Oct 2009 7:59pm UTC | ||
| From: | chx1975 at gmail dot com | Assigned to: | johannes | ||
| Status: | To be documented | Category: | PDO related | ||
| Version: | 5.2.5 | OS: | Linux | ||
| Votes: | 14 | Avg. Score: | 4.7 ± 0.6 | Reproduced: | 12 of 13 (92.3%) |
| Same Version: | 2 (16.7%) | Same OS: | 6 (50.0%) | ||
[16 Feb 2008 3:26am UTC] chx1975 at gmail dot com
[16 Feb 2008 3:29am UTC] larry at garfieldtech dot com
I can duplicate this problem. The issue appears to be that by default, MySQL will return the number of affected rows from a previous UPDATE statement, not the number of matched rows. That values will differ if the update statement would set a row to its existing value. With ext/mysql and ext/mysqli, it can be set to return matched rows instead. PDO does not appear to have a way to allow that.
[23 Oct 2008 1:34am UTC] chx1975 at gmail dot com
An attempt to fix this can be found at http://drupal4hu.com/php-44135.patch . I added a number of flags not just the one I needed. running <?php $p = new PDO('mysql:host=localhost;dbname=test', 'root', '', array(PDO::MYSQL_ATTR_CLIENT_FLAGS => PDO::MYSQL_CLIENT_FOUND_ROWS)); $p->exec('TRUNCATE a'); $p->exec('INSERT INTO a VALUES (1)'); echo $p->exec('UPDATE a SET a = 1 WHERE a = 1'); $p = new PDO('mysql:host=localhost;dbname=test', 'root', ''); echo $p->exec('UPDATE a SET a = 1 WHERE a = 1'); ?> shows a 1 (one row found) and then a 0 (0 updated) so the patch seems to work.
[23 Oct 2008 1:25pm UTC] johannes@php.net
Thanks for the patch, a few comments/questions: - Why are you renaming the connect_opts variable? Any particular reason? - You shouldn't use the numeric values, as they might change, but the values provided by the client library, this also ensures that only flags supported by the library are being used. - I think the SSL flag won't work without specific SSL certs & stuff, but I have to check that myself
[23 Oct 2008 7:55pm UTC] chx1975 at gmail dot com
I renamed it to what MySQL calls it. Please just drop the defines then, I copied them from mysql_com.h -- sorry, I am a n00b in doing this. Please also drop any client flags you do not feel useful.
[27 Oct 2008 6:36pm UTC] johannes@php.net
This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. New attributes PDO::MYSQL_ATTR_FOUND_ROWS and PDO::MYSQL_ATTR_IGNORE_SPACE added which can be used while connecting: $p = new PDO($dsn, $u, $p, array(PDO::MYSQL_ATTR_FOUND_ROWS => true, PDO::MYSQL_ATTR_IGNORE_SPACE=> true));
[21 Feb 2009 11:48pm UTC] kamazee at gmail dot com
This issue is still actual for stable releases _after_ the PHP 5.2.5 (tested 5.2.6 for Linux and 5.2.8 for Windows). Hope, changes will appear in stable branch soon.
[5 Aug 2009 6:54pm UTC] lordbyron at sogetthis dot com
Bug still occurs in php 5.2.9, on 64 bit linux. Appears that constant PDO::MYSQL_ATTR_FOUND_ROWS was not added to this version or removed as PDO driver does not recognize it.
[22 Sep 2009 1:17am UTC] sadrak at sogetthis dot com
Verified this constant still does not exist in php 5.2.10.
[2 Oct 2009 7:48pm UTC] lordbyron at sogetthis dot com
Still doesn't exist in 5.2.11, nor does something which would accomplish the same goal.
[2 Oct 2009 7:59pm UTC] uw@php.net
It is in 5.3+ and not in 5.2 because its a new feature.
[2 Oct 2009 9:12pm UTC] chx1975 at gmail dot com
So dropping a feature found in both older SQL drivers is not considered a bug?
