PHP Bugs  
php.net | support | documentation | report a bug | advanced search | search howto | statistics | login

go to bug id or search bugs for  

Bug #34783 Contradictory errors using ArrayAccess
Submitted:7 Oct 2005 6:33pm UTC Modified: 7 Oct 2005 11:09pm UTC
From:oliver dot graetz at gmx dot de Assigned to:
Status:Bogus Category:SPL related
Version:5.1.0RC1 OS:WinXP, Debian Linux
View/Vote Developer Edit Submission

[7 Oct 2005 6:33pm UTC] oliver dot graetz at gmx dot de
Description:
------------
I wrote a class implementing ArrayAccess that should behave like a
normal array to the outside world. So If I used an element in this array
it should be usable like any other array. But there was a problem if the
"array" elements were arrays themselves. I got this error:

Fatal error: Objects used as arrays in post/pre increment/decrement must
return values by reference in t.php on line 123

OK, you want a reference, you get it. I changed offsetGet to &offsetGet.
This worked fine with PHP5.0. But in PHP5.1 the parser became more picky
about this:

Fatal error: Declaration of WAF_Config::offsetGet() must be compatible
with that of ArrayAccess::offsetGet() in myclass.php on line 234

This is correct but it makes implementing ArrayAccess in a way
consistent with ordinary arrays impossible!

Reproduce code:
---------------
<?php
class test implements ArrayAccess
{
    private $data=array();

    function offsetSet($key,$value) { $this->data[$key] = $value; }
//    function &offsetGet($key) { return $this->data[$key]; }
    function offsetGet($key) { return $this->data[$key]; }
    function offsetUnset($key)
    {
        if (array_key_exists($key,$this->data)) {
unset($this->data[$key]); }
    }
function offsetExists($key) { return array_key_exists($key,$this->data);
}
}

$t=new test();
$t['huba']=array('one','two');
$t['huba'][]='three';
print_r($t['huba']);

Expected result:
----------------
Array ( [0] => one [1] => two [2] => three ) 

Actual result:
--------------
using offsetGet
Fatal error: Objects used as arrays in post/pre increment/decrement must
return values by reference in t.php on line 17

using &offsetGet
Fatal error: Declaration of test::offsetGet() must be compatible with
that of ArrayAccess::offsetGet() in t.php on line 2

[7 Oct 2005 7:07pm UTC] oliver dot graetz at gmx dot de
Sorry, I thought I checked everything but I found something similar to
this bug here as a comment:

http://bugs.php.net/bug.php?id=32983

Still, I think that
"We found out that this is not solvable without blowing up the interface
and creating a BC or providing an additional interface to support
references and thereby creating an internal nightmare - actually i don't
see a way we can make that work ever."
is not an acceptable answer. Using &offsetGet worked fine in 5.0. An, as
I found out, this works in PHP5.0 without &offsetGet:

$entry=&$test->offsetGet('valid_op');
$entry[]='three';

So, PHP5.1 didn't fix the interface parser but instead introduced a BC
break.
[7 Oct 2005 7:14pm UTC] oliver dot graetz at gmx dot de
One more point: Adding the & outside of the class just allows
referencing under PHP5.0 but not under 5.1. But having references is in
no way unfixable under 5.1:

class test
{
// rest as before
function &offsetGetRef($key) { return $this->data[$key]; }
}

$t=new test();
$t['huba']=array('one','two');
$entry=&$t->offsetGetRef('huba');
$entry[]='three';
print_r($t['huba']);

Voilą! It works. Telling that it's unfixable just doesn't do the issue
justice. Perhaps the fix is more difficult but it can be done. And "we
didn't mean to support references in the first place" isn't valid since
normal arrays are meant to be used this way and ArrayAccess was meant to
mimic this for objects.
[7 Oct 2005 8:20pm UTC] helly@php.net
Thank you for taking the time to write to us, but this is not
a bug. Please double-check the documentation available at
http://www.php.net/manual/ and the instructions on how to report
a bug at http://bugs.php.net/how-to-report.php

Just to state this again: IT IS IMPOSSIBLE TO HAVE ARRAYACCESS DEAL WITH
REFERENCES.

If you don\'t like that statement i suggest you prove it wrong by
writing a patch that actually works in all cases.
[7 Oct 2005 9:41pm UTC] oliver dot graetz at gmx dot de
Won't happen. I'm just a user of PHP. As a result, this is one more case
where using a new feature becomes impossible by breaking BC (between 5.0
and 5.1). A yound and promising feature has to be left behind,
ArrayAccess won't be in use any more in future projects by certain
people since the desired behaviour can easily be achieved by using
ordinary methods. Syntactic sugar going to hell.
[7 Oct 2005 10:40pm UTC] oliver dot graetz at gmx dot de
Why did this work in 5.0.3 by using &offsetGet() and can't be made to
work in 5.1? Why would changing the interface to read &offsetGet break
anything other than the (up to now) few apps DEFINING it without the
ampersand? 5.0 didn't complain about this at all and it worked. The
issues caused by a simple change of the interface a far inferior to
those caused by the "only variables can be passed by reference" some
weeks ago. And you're avoiding more serious trouble in later versions
when more and more applications are relying on the false behaviour?
[7 Oct 2005 11:09pm UTC] oliver dot graetz at gmx dot de
Perhaps there shouldn't be afix for the reference issues since they are
not meant to happen looking at the interface. But
$data['element']['element2']="hi"; should definitely work! Perhaps a fix
to look if the first part of this code is accessing an object instead of
a real array has to be applied. An ordinary user sees nothing of a
reference. Either fix this with ArrayAccess or completely yank the
interface! 

I see a future where more and more framework code is pretending to be an
array. If then users get this error message they won't understand the
world. "It's an array!? Where's the reference? Why the *#?* isn't this
working? I hate PHP5!"

If you implement code so something can look like an array than it MUST
be able to truely behave like an array.

RSS feed | show source 

PHP Copyright © 2001-2009 The PHP Group
All rights reserved.
Last updated: Sat Nov 21 10:30:49 2009 UTC