php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #76828 Libzip version is assumed to be an integer
Submitted: 2018-08-31 10:13 UTC Modified: 2018-09-09 15:26 UTC
From: office at jiripik dot com Assigned:
Status: Not a bug Package: Compile Failure
PHP Version: 7.2.9 OS: AWS Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: office at jiripik dot com
New email:
PHP Version: OS:

 

 [2018-08-31 10:13 UTC] office at jiripik dot com
Description:
------------
The latest libzip has MicroVersion 1a

SET(PACKAGE_VERSION_MICRO "1a")

which causes PHP build to complain that 

lizbip invalid suffix on integer constant version


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2018-09-09 11:07 UTC] ab@php.net
-Status: Open +Status: Feedback
 [2018-09-09 11:07 UTC] ab@php.net
Thanks for the report. Which exact version of libzip do you mean. I see this on the vanilla 1.5.1

$:~/src/libzip-1.5.1$ grep -rn PACKAGE_VERSION_MICRO .
./CMakeLists.txt:58:SET(PACKAGE_VERSION_MICRO "1")
.....

The installed header also contains all the version parts as integers. Likely it's about a particular disribution which patches the vanilla libs.

Thanks.
 [2018-09-09 12:34 UTC] office at jiripik dot com
-Status: Feedback +Status: Open
 [2018-09-09 12:34 UTC] office at jiripik dot com
Just look at https://github.com/nih-at/libzip/blob/master/CMakeLists.txt and you see 

SET(PACKAGE_VERSION_MICRO "1a")
 [2018-09-09 15:26 UTC] ab@php.net
-Status: Open +Status: Not a bug
 [2018-09-09 15:26 UTC] ab@php.net
Yeah, but that's not a released version. Fe look here https://github.com/nih-at/libzip/commit/b95cf3fdd4c1271f922017f092d02a878873425c . Seems it's just a way libzip devs mark a dev version. If it appears in a released version, probably a lot of other packages would be broken. It doesn't look like there is some action need in a consumer project, especially as one can't really tell some version were a dev version. I'd suggest you to file a report on the libzip side, perhaps some extra macro can be introduced to tell whether it's a dev version, like fe PHP does.

Thanks.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Mar 29 09:01:28 2024 UTC