php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #73214 krb5-config usage inadvertently skipped
Submitted: 2016-09-30 21:29 UTC Modified: 2016-11-26 23:55 UTC
From: michael at orlitzky dot com Assigned: stas (profile)
Status: Closed Package: *Compile Issues
PHP Version: 7.0.11 OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: michael at orlitzky dot com
New email:
PHP Version: OS:

 

 [2016-09-30 21:29 UTC] michael at orlitzky dot com
Description:
------------
One of our ./configure options is --with-kerberos=<DIR>. The value of <DIR> gets stored in the PHP_KERBEROS variable if a directory is supplied. There is a function in aclocal.m4:

AC_DEFUN([PHP_SETUP_KERBEROS],[
  ...

  dnl If krb5-config is found try using it
  if test "$PHP_KERBEROS" = "yes" && test -x "$KRB5_CONFIG"; then
    KERBEROS_LIBS=`$KRB5_CONFIG --libs gssapi`
    KERBEROS_CFLAGS=`$KRB5_CONFIG --cflags gssapi`
  ...

The krb5-config program is the preferred way to figure out which libs/flags are needed to build with kerberos support, because it works with both the MIT and Heimdal implementations. However, if you look carefully at the test, it's checking the value of <DIR> against "yes". Naturally that fails; instead it should be

  test "$PHP_KERBEROS" != "no"

Doing so prevents the MIT lib names from getting appended when the Heimdal implementation is used. In other words, krb5-config works, it just isn't getting used.




Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-11-26 23:55 UTC] stas@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: stas
 [2016-11-26 23:55 UTC] stas@php.net
The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sat Apr 20 06:01:28 2024 UTC