php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #66327 Feedback on New 1.5 optimizations
Submitted: 2013-12-20 01:31 UTC Modified: 2014-01-10 23:44 UTC
From: Terry at ellisons dot org dot uk Assigned: laruence (profile)
Status: Closed Package: opcache
PHP Version: master-Git-2013-12-20 (Git) OS: N/A
Private report: No CVE-ID: None
 [2013-12-20 01:31 UTC] Terry at ellisons dot org dot uk
Description:
------------
Xinchen,

You might be interested in the referenced PHPT which demonstrates how we can test the new optimizations introduced in Pass 1.5, which is the real point of this bugrep.  

I've gone through the function related ones and these seen to be fine, though it's a shame that we can't broaden the scope of these within B/C behaviours.

One minor Q - the optimizations don't include class_exists() optimization for builtin classes and ditto is_callable() doesn't support builtin method probs such as "Reflection::export".  Is there any reason for this?  If we are happy with then please update line 82 of the test.

I thought that I could create fail paths if the enable_dl directive is set with cached compiled scripts, but on reflection as this is disabled by all of the SAPIs which OPcache caches, this isn't an issue.   

If this isn't of interest then just close the rep.  //Terry

Test script:
---------------
https://gist.github.com/TerryE/8048948


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-12-20 03:21 UTC] laruence@php.net
-Assigned To: +Assigned To: laruence
 [2014-01-10 23:44 UTC] Terry at ellisons dot org dot uk
-Status: Assigned +Status: Closed
 [2014-01-10 23:44 UTC] Terry at ellisons dot org dot uk
Closed by O/P
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Thu Aug 22 16:01:28 2019 UTC