php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #61460 popen_close_error-win32 expected output is wrong
Submitted: 2012-03-20 22:54 UTC Modified: 2012-04-03 12:30 UTC
From: mattficken@php.net Assigned: ab (profile)
Status: Closed Package: Testing related
PHP Version: 5.3.10 OS: Windows
Private report: No CVE-ID: None
 [2012-03-20 22:54 UTC] mattficken@php.net
Description:
------------
Warning messages have changed since test written. Expected output is incorrect. See patch.

Expected result:
----------------
test pass

Actual result:
--------------
test fail



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-03-20 22:56 UTC] mattficken@php.net
This patch fixes it:

20c20
< echo "*** Testing for error conditions ***\n";
---
> echo "*** Testing for error conditions ***".PHP_EOL;
22a23
> 
23a25
> 
29c31
< echo "\n--- Done ---";
---
> echo PHP_EOL.PHP_EOL."--- Done ---";
44,46c46,48
< resource(%d) of type (stream)
< 'abc.txt' is not recognized as an internal or external command,
< operable program or batch file.
---
> 
> Warning: popen(abc.txt,rw): Invalid argument in %s on line %d
> bool(false)
57c59,61
< --- Done ---
---
> 
> --- Done ---'abc.txt' is not recognized as an internal or external command,
> operable program or batch file.
 [2012-04-02 22:59 UTC] mattficken@php.net
This patch passes on PHP5.3.11rc1 on Windows 7 sp1x64.

It does not break for me on Linux x64 (Gentoo and Fedora 16) with PHP5.3.11rc1.
 [2012-04-03 12:28 UTC] mattficken@php.net
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src.git;a=commit;h=438536e45e1f762fd0f0fe7d9243adb63074e55d
Log: Fix bug #61460 popen_close_error-win32 expected output is wrong
 [2012-04-03 12:30 UTC] ab@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: ab
 [2012-04-03 12:30 UTC] ab@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 [2014-10-07 23:27 UTC] stas@php.net
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=438536e45e1f762fd0f0fe7d9243adb63074e55d
Log: Fix bug #61460 popen_close_error-win32 expected output is wrong
 [2014-10-07 23:38 UTC] stas@php.net
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=438536e45e1f762fd0f0fe7d9243adb63074e55d
Log: Fix bug #61460 popen_close_error-win32 expected output is wrong
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Thu Jun 27 06:01:31 2019 UTC