php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #59427 APC 3.1.4 does not compile without -DAPC_POOL_DEBUG
Submitted: 2010-09-16 23:18 UTC Modified: 2010-09-22 08:58 UTC
From: tstarling@php.net Assigned:
Status: Closed Package: APC (PECL)
PHP Version: 5.3.2 OS: Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: tstarling@php.net
New email:
PHP Version: OS:

 

 [2010-09-16 23:18 UTC] tstarling@php.net
Description:
------------
Using APC from http://svn.php.net/repository/pecl/apc/tags/APC_3_1_4

.../APC_3_1_4/apc_pool.c: In function ?apc_pool_init?:
.../APC_3_1_4/apc_pool.c:455: error: ?APC_POOL_SIZEINFO? undeclared (first use in this function)
.../APC_3_1_4/apc_pool.c:455: error: (Each undeclared identifier is reported only once
.../APC_3_1_4/apc_pool.c:455: error: for each function it appears in.)
.../APC_3_1_4/apc_pool.c:455: error: ?APC_POOL_REDZONES? undeclared (first use in this function)

In apc_pool.h:

#if APC_POOL_DEBUG
    APC_POOL_REDZONES  = 0x08,
    APC_POOL_SIZEINFO  = 0x10,
    APC_POOL_OPT_MASK  = 0x18
#endif

But the usage in apc_pool.c does not have the #if. 


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-09-17 07:36 UTC] gopalv82 at yahoo dot com
This kinda puzzles me.

None of my pre-release builds failed, but it is a stupid mistake of mine.

I have no clue why gcc-4.4.3 doesn't complain about it.
I suspect assert() calls are treated as being special.

Rasmus has immediately fixed it in SVN, 

http://svn.php.net/viewvc/pecl/apc/trunk/apc_pool.c?r1=301694&r2=301964

I plan to push out apc-3.1.5 before I start doing some
more performance stuff.

Is 3.1.4 working otherwise for you guys?
 [2010-09-17 09:08 UTC] tstarling at wikimedia dot org
I have PHP configured in debug mode, so that probably changes what kind of macro assert() is. 

Yes, 3.1.4 seems to be working so far other than this.
 [2010-09-22 08:58 UTC] gopalv82 at yahoo dot com
Fixed in SVN
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Apr 18 04:01:27 2024 UTC