php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #38413 ext/standard/tests/file/bug22414.phpt unnecessary code
Submitted: 2006-08-10 13:11 UTC Modified: 2006-08-10 13:44 UTC
From: chtekk at gentoo dot org Assigned:
Status: Closed Package: Unknown/Other Function
PHP Version: 4.4.3 OS: Gentoo Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: chtekk at gentoo dot org
New email:
PHP Version: OS:

 

 [2006-08-10 13:11 UTC] chtekk at gentoo dot org
Description:
------------
While running the test suite, Gentoo's sandbox (a mechanism to keep the building and testing of packages separate from the actual system, fex. denieing random access to files outside the build dir) failed telling me about a "unlink /passthru_test" in ext/standard/tests/file/bug22414.phpt, checking that test shows that on both PHP4_4, 5_1 as well as 5_2 branches it has the following code in it:

@unlink($pwd . '/passthru_test');

That code seems unnecessary and useless to me, as well as incorrect. $pwd never gets defined or used in any way in the rest of that test, and that passthru_test file is not used anywhere. Please fix the test by removing that line, you'll find working diffs for PHP4 and PHP5 at the following urls:

http://overlays.gentoo.org/proj/php/browser/patches/php-patches/4.4.3/4.4.3/php4.4.3-test_bug22414.patch?format=txt
http://overlays.gentoo.org/proj/php/browser/patches/php-patches/5.1.4/5.1.4/php5.1.4-test_bug22414.patch?format=txt

Expected result:
----------------
A working patch. ;)


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2006-08-10 13:44 UTC] tony2001@php.net
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Mar 29 12:01:27 2024 UTC