PHP :: Request #64671 :: NACKs are exactly like ACKs

NACKs are exactly like ACKs

Submitted:

2013-04-18 18:46 UTC

Modified:

2014-12-07 19:07 UTC

Votes:	4
Avg. Score:	4.5 ± 0.9
Reproduced:	4 of 4 (100.0%)
Same Version:	2 (50.0%)
Same OS:	3 (75.0%)

From:

mi+php at aldan dot algebra dot com

Assigned:

pierrick (profile)

Status:

Closed

Package:

stomp (PECL)

PHP Version:

Irrelevant

OS:

All

Private report:

CVE-ID:

None

View Add Comment Developer Edit

[2013-04-18 18:46 UTC] mi+php at aldan dot algebra dot com

Description:
------------
Though the package provides a convenience function/method for generating ACK-frames, there is no support for NACKs -- these have to be built by hand.

My patch adds stomp_nack as an alias for stomp_ack and modifies the function to use one of the two commands depending on how it was invoked.

Patches

stomp-patch-whitespace-at-eol (last revision 2013-04-18 18:49 UTC by mi+php at aldan dot algebra dot com)
stomp-patch-nack (last revision 2013-04-18 18:47 UTC by mi+php at aldan dot algebra dot com)

Add a Patch

Pull Requests

Pull requests:

Bug 64671 - NACKs are exactly like ACKs (pecl-tools-stomp/3)

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports

[2013-04-25 18:49 UTC] pierrick@php.net

-Assigned To: +Assigned To: pierrick

[2014-12-07 18:22 UTC] pierrick@php.net

Automatic comment on behalf of pierrick@webstart.fr
Revision: http://git.php.net/?p=pecl/tools/stomp.git;a=commit;h=189b8dcfc211f9699f0bb6df7f6aff07fae6faa0
Log: Fixed bug #64671 (Add stomp_nack and Stomp::nack functions).

[2014-12-07 18:22 UTC] pierrick@php.net

-Status: Assigned +Status: Closed

[2014-12-07 18:52 UTC] mi+php at aldan dot algebra dot com

So you didn't like the code looking at the argv[0], as my patch was doing?

[2014-12-07 19:07 UTC] pierrick@php.net

Not really :) I think the code is much clearer that way. No obscure things in it. But thanks for the patch anyway !

	php.net \| support \| documentation \| report a bug \| advanced search \| search howto \| statistics \| random bug \| login
go to bug id or search bugs for


Copyright © 2001-2024 The PHP Group All rights reserved.	Last updated: Tue Apr 23 15:01:32 2024 UTC