php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #81480 [bugs.php.net] search: replace the package_nname select with a single checkbox
Submitted: 2021-09-26 12:17 UTC Modified: -
From: ddpm at liscovius dot de Assigned:
Status: Open Package: Website problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
(description)
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: ddpm at liscovius dot de
New email:
PHP Version: OS:

 

 [2021-09-26 12:17 UTC] ddpm at liscovius dot de
Description:
------------
Currently, there are 2 selects package_name[] and package_nname[].

These select are having too many options. Selecting all packages in both of them results in a 24KB GET request which the web server denies.

Also it makes IMHO no sense to have both as there is no logical reason to have 2 selects as they are AND in the SQL.

Instead as little mitigation use a simple NO checkbox there.

The SQL uses then 

NOT IN(packagelist) instead of

IN(packagelist)

in the WHERE conditions.

Beside simpler form, the requests are now max half the size, around 12KB.
Also too big to be handled by web server, but a step forward.



Actual result:
--------------
Search form is more complex than necessary.



Patches

Add a Patch

Pull Requests

Add a Pull Request

 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Apr 30 15:01:31 2024 UTC