|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2003-08-04 03:22 UTC] rehsack at liwing dot de
Description:
------------
The method call_user_func ignores requirement of called
function takes it's arguments as reference. The results
in several times very ugly and hard to find bugs, eg. if
you use a template pattern combined with composite to
control child templates and want to do an action in each
child object and require to work on current data copy.
Either, if call_user_func internally is able to be called
by reference, some programs could be speed up, too (because
of the loose of expensive string copies)
This bug may related to #24631 but seems to have another
background. I can submit a more complicated example using
templates and a composite object to illustrate the problem.
Enabling call-time references in php.ini would solve this
problem by don't write a warning but I don't think it's
a good way to solve...
Reproduce code:
---------------
<?PHP
function nextId( &$id )
{
$id += 1;
}
$id = 1;
echo "before call_user_func id=$id\n";
call_user_func( "nextId", $id );
echo "after call_user_func id=$id\n";
call_user_func_array( "nextId", array( &$id ) );
echo "after call_user_func_array id=$id\n";
?>
Expected result:
----------------
before call_user_func id=1
after call_user_func id=2
after call_user_func_array id=3
Actual result:
--------------
before call_user_func id=1
after call_user_func id=1
after call_user_func_array id=2
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Sun Oct 26 19:00:01 2025 UTC |
Hi Ilia, your wrong, because: $ cat test1.php <?PHP function nextId( &$id ) { $id += 1; } $id = 1; echo "before call_user_func id=$id\n"; call_user_func( "nextId", &$id ); echo "after call_user_func id=$id\n"; call_user_func_array( "nextId", array( &$id ) ); echo "after call_user_func_array id=$id\n"; ?> $ php test1.php Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of call_ user_func(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /var/www/data/trevor/flexpage/test/php-bugs/test1.php on line 10 before call_user_func id=1 after call_user_func id=2 after call_user_func_array id=3 This gives the wanted result but prints out a warning. By the way, I don't want to discus whether call_user_func is implemented as described neither it's not working as designed. I want to tell you (as php team), that the design might be wrong. Either, if you (as php team) don't have any plans to extend the design (what shouldn't be to complicated), I consider you update the documentation that way, that you describe that call_user_func will duplicate the given argument. call_user_func is not an intelligent function (what it could be), it's a dumb one (this is not an offending but it is like a dumb terminal as some old unix ones). I want to consider by this bug report to rewrite call_user_func becomes intelligent (looks what kind of argument is required and calls that way). Otherwise I had to open a documentation bug, because this behaviour should be documented explicitely.This bug has been fixed in the documentation's XML sources. Since the online and downloadable versions of the documentation need some time to get updated, we would like to ask you to be a bit patient. Thank you for the report, and for helping us make our documentation better. "Note that the parameters for call_user_func are not passed by reference." + example: <?php function increment(&$var) { $var++; } $a = 0; call_user_func('increment', $a); echo $a; // 0 call_user_func_array('increment', array(&$a)); // You can use this instead echo $a; // 1 ?>