php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #10168 openssl.c function uses an undeclared variable
Submitted: 2001-04-04 15:48 UTC Modified: 2001-05-06 14:18 UTC
From: martin at bugs dot unl dot edu dot ar Assigned:
Status: Closed Package: Compile Failure
PHP Version: 4.0 Latest CVS (04/04/2001) OS: Solaris
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2001-04-04 15:48 UTC] martin at bugs dot unl dot edu dot ar 
openssl.c: In function `asn1_time_to_time_t':
openssl.c:459: `is_dst' undeclared (first use in this function)
openssl.c:459: (Each undeclared identifier is reported only once
openssl.c:459: for each function it appears in.)
make[1]: *** [openssl.lo] Error 1
make[1]: Leaving directory `/space/pruebas/php4/ext/openssl'
make: *** [all-recursive] Error 1

is_dst (as I saw in some other c files) should be defined at the begining of the function `asn1_time_to_time_t', but it's not.
So I declared it as int with default value -1 and looks like that fixed it.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-04-05 04:48 UTC] wez@php.net 
Thanks for pointing this out.

That line should read:

gmadjust = -(thetime.tm_isdst ? timezone - 3600 : timezone + 3600);

so thats thetime.tm_isdst instead of is_dst.

Sorry about that - my system has gmtoff, so I didn't catch this.

Please either update your CVS or make the change and confirm that this works correct.
 [2001-05-06 14:18 UTC] jmoore@php.net 
Fixed && no Feedback
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Apr 25 17:01:29 2024 UTC