php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #49924 The PHP documentation system needs to be able to render screenshots better
Submitted: 2009-10-19 17:00 UTC Modified: 2009-11-04 21:42 UTC
From: ruslany at microsoft dot com Assigned:
Status: Closed Package: Website problem
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID: None
View Developer Edit
 [2009-10-19 17:00 UTC] ruslany at microsoft dot com 
Description:
------------
Currently, when I use the <mediaobject> element to insert a screenshot, it gets rendered inside of a gray box, which is wider than the actual screenshot. Because of that the screenshot does not look good as it gets blended with the background. You can see the examples here: http://docs.php.net/manual/en/install.windows.iis7.php

The PhD should support better rendering of the images and should not surround them with the gray background.

As was suggested by Hannes, this could be controlled by the attibute on the <example> element, e.g. role="screenshot".

Reproduce code:
---------------
<mediaobject>
 <imageobject>
  <imagedata fileref="path to file" />
 </imageobject>
</mediaobject>

Expected result:
----------------
There should not be gray background for the screenshots.

Actual result:
--------------
http://docs.php.net/manual/en/install.windows.iis7.php. See the gray backgrounds around screenshots.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2009-10-20 14:34 UTC] rquadling@php.net 
The CSS responsible for this is in div.mediaobject from site.css line 
880 ish.

Index: site.css
===================================================================
--- site.css	(revision 289798)
+++ site.css	(working copy)
@@ -879,7 +879,6 @@
 
 div.example div.example-contents,
 table .phpcode,
-div.mediaobject,
 div.classsynopsis,
 div.informalexample pre,
 div.informalexample .phpcode {
@@ -887,6 +886,11 @@
 	margin: 10px;
 	border: 1px outset #000;
 }
+
+div.mediaobject {
+	margin: 10px;
+}
+
 div.example-contents pre {
 	background-color: #e1e1e1;
 }


would remove the background and border but keep the margin.
 [2009-10-26 16:03 UTC] rquadling@php.net 
As the css used by PhD is the site's css file this is really a website 
issue.

Any chance that a phd.css file could be created which allows the 
phodoc team style the manual without impacting on the main css files?

Either way, the following patch does the trick of removing the border 
and background colouring, but keeps the margin.



Index: php/trunk/styles/site.css
===================================================================
--- php/trunk/styles/site.css	(revision 289798)
+++ php/trunk/styles/site.css	(working copy)
@@ -879,7 +879,6 @@
 
 div.example div.example-contents,
 table .phpcode,
-div.mediaobject,
 div.classsynopsis,
 div.informalexample pre,
 div.informalexample .phpcode {
@@ -887,6 +886,11 @@
 	margin: 10px;
 	border: 1px outset #000;
 }
+
+div.mediaobject {
+	margin: 10px;
+}
+
 div.example-contents pre {
 	background-color: #e1e1e1;
 }
 [2009-11-04 21:42 UTC] svn@php.net 
Automatic comment from SVN on behalf of bjori
Revision: http://svn.php.net/viewvc/?view=revision&revision=290219
Log: Fixed bug#49924 (The PHP documentation system needs to be able to render screenshots better)
# Patch by rquadling@
 [2009-11-04 21:42 UTC] bjori@php.net 
This bug has been fixed in SVN. Since the websites are not directly
updated from the SVN server, the fix might need some time to spread
across the globe to all mirror sites, including PHP.net itself.

Thank you for the report, and for helping us make PHP.net better.
 
PHP Copyright © 2001-2026 The PHP Group
All rights reserved. 		Last updated: Thu Oct 08 11:00:02 2026 UTC