|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2003-06-05 02:28 UTC] thomas at nimstad dot com
Problem:
fread() hangs if not reading exact number of bytes from a socket. worked previously in 4.3.1.
fread() returns max 1024 bytes even if specifying larger numbers. worked previously in 4.3.1.
Worked previously (snipped):
$fp = fsockopen("localhost", 5410, $errno, $errstr, 100);
// Send request
if (!fputs($fp, $packet, strlen($packet))) { }
// Read result header
while (!feof($fp)) {
$line = fgets($fp);
if ($line != "\n" && $line != "\r\n") {
$header .= $line;
}
else {
if (preg_match('/Content-Length: (\d+)/i', $header, $matches))
$length = $matches[1];
if (preg_match('/X-Session-Id: (\d*)/i', $header, $matches))
$session = $matches[1];
break;
}
}
// Read result body
$reply = fread($fp, $length);
This hangs the executions until timeout (30 sec).
Have to change the read result body to:
while (!feof($fp) && $length > 0) {
$size = min(1024, $length);
$reply .= fread($fp, $size);
$length -= $size;
}
All examples in documentation and even the PEAR/XML-RPC class states the "old" way what it looks to me.
What's up? New settings that i'm not aware of?
/Thomas
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Fri Oct 24 02:00:01 2025 UTC |
I too am experiencing this changed behavior. Previously, my code was as follows: $contents = fread ($fp, 2097152); And that would return up to 2mb from the given socket. In my case, the socket was a fopen() url. However, when I upgraded to PHP 4.3.2 it would ONLY return 2481 bytes no matter what. As a quick fix I had to move the fread() inside of a while loop, in order to fix this issue. Like this: $contents = ""; while (($data = fread ($fp, 2097152)) !== "") { $contents .= $data; } The only change on my system and the files being read was my upgrading to PHP 4.3.2. This definitely appears to be changed behavior of fread(). -PJThis is your loop: while (!feof($fp) && $length > 0) { $size = min(1024, $length); $reply .= fread($fp, $size); $length -= $size; } It looks wrong to me, since you are not checking the return value of fread and are just assuming that it read the chunk you asked for. This is a better loop: while ($length > 0) { $size = min(8192, $length); $data = fread($fp, $size); if (strlen($data) == 0) { break; // EOF } $reply .= $data; $length -= strlen($data); } It is recommended that you fread() in chunks of 8kb from sockets, as you will get better performance than using a smaller value. Using a larger value is wasteful as the streams layer will only allocate in 8KB chunks; Win32 has a maximum internal packet size of 8KB too. I'm marking this as bogus since it is the expected behaviour of PHP (I actually spent a couple of days correcting and testing this for HTTP/1.1 keep alives).