get_class() only returns user defined classes in lowercase.

Classes defined in extensions are returned in their original notation.

Making this a documentation problem.

Well, I suppose it is a documentation problem of sorts ... but my preference would be for the get_class() function to be consistent, regardless of whether the class is user-defined or extention-defined.

Any reason why this shouldn't be consistent?

- Colin

Seems strange.  Docs have been updated to reflect current 
behavior.  Changing status to 'feedback'.

I *really* don't think this should be a documentation fix, I think the get_class() function needs to be changed to always return lowercase.

Here is the required patch:


cmv@vincent:/usr/local/sources/php4/Zend$ diff -u zend_builtin_functions.c NEW.zend_builtin_functions.c 
--- zend_builtin_functions.c    Thu Nov 22 16:49:26 2001
+++ NEW.zend_builtin_functions.c        Thu Nov 22 16:51:30 2001
@@ -458,7 +458,8 @@
 {
        zval **arg;
        zend_class_entry *ce;
-
+       char *lcname;
+
        if (ZEND_NUM_ARGS()!=1 || zend_get_parameters_ex(1, &arg)==FAILURE) {
                ZEND_WRONG_PARAM_COUNT();
        }
@@ -467,7 +468,10 @@
        }
 
        ce = Z_OBJCE_PP(arg);
-       RETURN_STRINGL(ce->name, ce->name_length, 1);
+       lcname = estrndup(ce->name, ce->name_length);
+       zend_str_tolower(lcname, ce->name_length);
+
+       RETURN_STRINGL(lcname, ce->name_length, 1);
 }
 /* }}} */


- Colin

OK, but this docfix was right, as this is the current
case, and it should be documented. If this patch goes
throuh, and it arrives in some version, we can add
a note, that this strange behaviour existed till eg.
4.1.0 and it is corrected after that release...

Has already been documented.