I do not see the problem when I build oniguruma 6.7.1 by itself outside of PHP.

It looks like one needs to #include <limits.h> in order to get the definitions of INT_MAX and LONG_MAX. The oniguruma source code does do that, but only if its configure script determined that the header exists; it sets HAVE_LIMITS_H when that's the case. It doesn't look like PHP runs oniguruma's configure script, so it's not set.

I am able to build successfully by adding "-DHAVE_LIMITS_H=1" to CFLAGS, but of course I shouldn't have to do that.

Odd, because normally limits.h is checked in the configure step.

Thanks for the report. What are the configure flags? Especially, is --disable-mbregex used?

Thanks.

I'm building mbstring as a separate extension, using MacPorts. (I'm the MacPorts maintainer of PHP.) The only configure flags are:

--prefix=/opt/local --with-php-config=/opt/local/bin/php-config72

The configure output doesn't mention limits.

Ah, that explains it. Extensions in the core are usually not prepared for phpize usage. In this particular case, the config expects an in core path, so it can create conifig.h dynamically. Anything prevents to compile shared in the core?

Thanks.

Extensions in core have worked fine with phpize until now. I'm not sure what further feedback you're asking me to provide...

Nope, by luck they could have worked, but otherwise there are cases where it depends on the exact paths. In general, it is better to compile in core. 

Especially it's to see you use 7.2 config but the ticket tells mbstring is from 7.3. The compatibility is not guaranteed. Otherwise, it looks like configure doesn't create config.h for oniguruma or it is wrong in some way, but under this constellation i'm not sure which config is used at all. Please be sure you at least use php-config for 7.3 in first place, oniguruma/src/config.h is created after the configure and include paths point to the correct location.

Thanks.

Yes, I am using php-config73; apologies for the above typo.

Sorry, my mistake!  When updating the bundled Oniguruma to
6.7.1[1], I've overlooked that it requires limits.h as of
Oniguruma 6.4.0.

The attached patch should resolve the build failure.

[1] <https://github.com/php/php-src/commit/d48b233991c6ae916ca2b7e8d7c965fbc7eb00b7>
[2] <https://github.com/kkos/oniguruma/commit/f6db0dde64e4b6a806e52f45307459d433803094>

Thanks, that patch works for me.