php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #73385 xxhash for hash extension
Submitted: 2016-10-25 09:03 UTC Modified: 2021-02-21 12:51 UTC
Votes:7
Avg. Score:4.1 ± 0.8
Reproduced:6 of 6 (100.0%)
Same Version:3 (50.0%)
Same OS:2 (33.3%)
From: spam2 at rhsoft dot net Assigned: ab (profile)
Status: Closed Package: hash related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
View Developer Edit
 [2016-10-25 09:03 UTC] spam2 at rhsoft dot net 
Description:
------------
https://github.com/stuartherbert/php-xxhash

since we have now hash(ALGO, data) and hash_file(ALGO, data) and hash_algos() it would make more sense to have it as another algorithm than a out-of-tree module

the main usecase i see here is for etag-headers which needs to be fast and are not very collision critical in real life

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-10-25 14:52 UTC] cmb@php.net
-Type: Bug +Type: Feature/Change Request
 [2016-10-26 09:17 UTC] kalle@php.net 
Maybe you could contact the author and ask him to make an RFC and merge with the existing ext/hash extension, seems like an excellent inclusion for 7.2
 [2016-10-27 23:15 UTC] yohgaki@php.net 
Simple hash function addition to hash() function could be simply merged. There are number of useful hash functions out there. We may not want RFC for each of them. We may have RFC only when there is objection for adding new one.

I don't have a strong opinion for RFC requirement such changes, though.
 [2016-11-14 10:51 UTC] spam2 at rhsoft dot net 
why should the author make a RFC when the code exists and can be merged

and why does that need to wait until 7.2
 [2017-01-16 05:14 UTC] krakjoe@php.net
-Status: Open +Status: Feedback
 [2017-01-16 05:14 UTC] krakjoe@php.net 
Branches below 7.2 are supposed to be in feature freeze.

At least a pull request is required to add the new feature, this bug tracker does not generate the kind of consensus we require for adding this kind of new feature.

Please contact the author and request that a pull request is made on github.
 [2017-01-16 08:54 UTC] spam2 at rhsoft dot net
-Status: Feedback +Status: Open
 [2017-01-16 08:54 UTC] spam2 at rhsoft dot net 
What about the maintainer of ext/hash doing so - it makes little sense for users to sit in the middle of communication
 [2017-02-17 09:07 UTC] spam2 at rhsoft dot net 
> Branches below 7.2 are supposed to be in feature freeze

seriously?

when it's no problem to add a hash-related function to the core namespace how in the world is it a problem to add a algo where code already exists to that same codebase?

http://www.php.net/ChangeLog-7.php#7.1.2
Hash:
  Added hash_hkdf() function.
  Fixed bug #73961 (environmental build dependency in hash sha3 source).
 [2021-02-21 12:51 UTC] ab@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: ab
 [2021-02-21 12:51 UTC] ab@php.net 
xxHash landed in master.

Thanks
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Nov 21 11:01:29 2024 UTC