Do you have a test script that replicates the behavior? I just test it and it worked without any issues.

Thanks!

Thanks for the reply.

Sorry for the missing test code.

For testing:
1. Create a ZIP file like "C:\Temp\Test.zip", 
   with a file inside like "Test.txt", 
   with a password encrypted like "pass".
2. Run the test-code Zip_Test().
3. The password is wrong, and you should have a file named "Test.txt" with the length 0 in "C:\Temp\".
4. It create the 'ERROR: extractTo' Error.

5. If "C:\Temp\Test.txt" already exists and has content, it will be overwritten.

tested on xampp, PHP Version 5.6.3, on windows 7



<?php

Zip_Test();

function Zip_Test () {

	$filePath = 'C:\\Temp\\Test.zip';
	$destinationDirectory = 'C:\\Temp\\';
	$password = 'pass_wrong';

	$zip = new ZipArchive;

	if ($zip->open($filePath) !== true)                  { print ('ERROR: open'); return; }
	if ($zip->setPassword($password) !== true)           { print ('ERROR: setPassword'); return; }
	if ($zip->extractTo($destinationDirectory) !== true) { print ('ERROR: extractTo'); return; }

	$zip->close();
	
}

ps:

...The argument is, if the password is wrong, it should not create/change any files.

I can confirm this issue. The problem is that libzip will only
check the password when the entry is actually opened. However, PHP
will first open the output stream, and only then call zip_fopen()[1],
so an empty file remains.

Simply changing the order (i.e. first zip_open() then
php_stream_open_wrapper()) should solve the issue.

[1] <https://github.com/php/php-src/blob/PHP-7.0.10/ext/zip/php_zip.c#L241-L253>