php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #68458 Change pm.start_servers default warning to notice
Submitted: 2014-11-19 22:43 UTC Modified: 2014-11-20 07:18 UTC
From: dz at heroku dot com Assigned: remi (profile)
Status: Closed Package: FPM related
PHP Version: 5.6.3 OS: OS X 10.8.5
Private report: No CVE-ID: None
View Developer Edit
 [2014-11-19 22:43 UTC] dz at heroku dot com 
Description:
------------
Unlike other settings, this has a perfectly reasonable default, calculated using a dynamic formula.

If the default were hardcoded to "2" or something, then it would make sense to have a warning, since that could potentially be bad, but for a dynamically calculated value based on other mandatory settings, a notice ought to be enough.

Patches

Pull Requests

Pull requests:

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2014-11-19 22:44 UTC] dz at heroku dot com 
Had to move the location of `zlog_set_level()` again (see https://bugs.php.net/bug.php?id=68381), see PR for details.
 [2014-11-20 07:15 UTC] remi@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1939097ededdbf1d42305e32f6a9947ff6a7e91f
Log: Fixed #68458 Change pm.start_servers default warning to notice
 [2014-11-20 07:15 UTC] remi@php.net
-Status: Open +Status: Closed
 [2014-11-20 07:16 UTC] remi@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dec0db79c3fc0c284cef9a04801b3d4d068522b2
Log: Fixed #68458 Change pm.start_servers default warning to notice
 [2014-11-20 07:18 UTC] remi@php.net
-Assigned To: +Assigned To: remi
 [2014-11-20 07:18 UTC] remi@php.net 
Commits:
http://git.php.net/?p=php-src.git;a=commitdiff;h=909d44f20dd00ccf3a6519707bfaba2ed30e8b2b
http://git.php.net/?p=php-src.git;a=commitdiff;h=befce20c84527181f760fb53e4d536f22e84953e
http://git.php.net/?p=php-src.git;a=commitdiff;h=49be4af42bdb4ae013cfd5a9739c1639056b7e12
http://git.php.net/?p=php-src.git;a=commitdiff;h=a128cbad578adbb2ca16ae84c8b2fef609067c8d

I also add a second test, your in "warning" level (nothing traced), another in "notice" level, to check everything is traced.
 [2014-11-20 09:18 UTC] remi@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1939097ededdbf1d42305e32f6a9947ff6a7e91f
Log: Fixed #68458 Change pm.start_servers default warning to notice
 [2014-11-26 16:21 UTC] ab@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dec0db79c3fc0c284cef9a04801b3d4d068522b2
Log: Fixed #68458 Change pm.start_servers default warning to notice
 [2014-11-26 16:21 UTC] ab@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1939097ededdbf1d42305e32f6a9947ff6a7e91f
Log: Fixed #68458 Change pm.start_servers default warning to notice
 [2016-07-20 11:40 UTC] davey@php.net 
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dec0db79c3fc0c284cef9a04801b3d4d068522b2
Log: Fixed #68458 Change pm.start_servers default warning to notice
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Nov 21 10:01:29 2024 UTC