php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #66298 ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend
Submitted: 2013-12-15 18:04 UTC Modified: 2013-12-30 03:12 UTC
From: dam at opencsw dot org Assigned: laruence (profile)
Status: Closed Package: opcache
PHP Version: 5.5.7 OS: Solaris
Private report: No CVE-ID: None
View Developer Edit
 [2013-12-15 18:04 UTC] dam at opencsw dot org 
Description:
------------
The file
  ext/opcache/Optimizer/zend_optimizer.c
has DOS ^M lineend. On Solaris this leads macros with line continuations \ to not work any more.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2013-12-16 07:53 UTC] laruence@php.net 
fixing this is simple. but it is difficult to keep previous commit history (I mean don't break git blame result) :<
 [2013-12-29 20:07 UTC] krakjoe@php.net
-Assigned To: +Assigned To: laruence
 [2013-12-29 20:07 UTC] krakjoe@php.net 
I assume this actually breaks opcache for Solaris, so is this fixed yet or what ?

Laruence, assigning to you to get some attention again, I think history is not important if the build (or opcache) is broken.
 [2013-12-30 02:54 UTC] laruence@php.net 
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=04c8ce259fb422c7bcdac3d72bacbf0ee910d772
Log: Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend)
 [2013-12-30 02:54 UTC] laruence@php.net
-Status: Assigned +Status: Closed
 [2013-12-30 02:54 UTC] laruence@php.net 
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=a88543a106fa2e43b3153d11987b577ec28f78c0
Log: Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend)
 [2013-12-30 03:12 UTC] laruence@php.net 
@krakjoe okey, fixed, thanks
 [2013-12-30 09:49 UTC] ab@php.net 
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=a88543a106fa2e43b3153d11987b577ec28f78c0
Log: Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend)
 [2013-12-30 09:49 UTC] ab@php.net 
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=04c8ce259fb422c7bcdac3d72bacbf0ee910d772
Log: Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Nov 21 09:01:32 2024 UTC