router is a especially script, if we set this as the script_name, what about the 
script which router routed to?

I appreciate that, but that assumes the router will route to another script on disk, rather than loading the required code and generating a response like most of the MVC frameworks do.

I'm split on this issue.

On one hand for consistency I think that the $_SERVER['SCRIPT_FILENAME'] should 
be set in the router script.

On the other hand, this is meant to be a test server NOT a production server, 
and the router script should simply be used to route, or rewrite URL's to 
another script, i.e. The router script shouldn't be used in production as is.

Either way the documentation should reflect this.

However I personally, after much thought think that $_SERVER['SCRIPT_FILENAME'] 
should be set, purely for consistency, after all, it is the filename of the 
running script.

Added a patch to add this functionality.

Sorry for the multiple comments..

I see what laruence was saying now about the script that has been 
routed to.

After playing around some more, I see what is meant by this.

If the router returns false, then the resource is served as is, and, if it is a 
PHP script, the $_SERVER['SCRIPT_FILENAME'] is set to the resource when the 
dispatched script is executed.  However, if we set the server variable as the 
router, SCRIPT_FILENAME variable will always point to the router.

So if you were to have the following code in your router:


<?php
var_dump($_SERVER['SCRIPT_FILENAME']);

if (preg_match('/\.(?:php)$/', $_SERVER["REQUEST_URI"]))
    return false;    // serve the requested resource as-is.
else { 
    include ("test.php");
}

And in test.php you had:

<?php
var_dump($_SERVER['SCRIPT_FILENAME']);


If you request /test.php the output is:

string(43) "/home/sam/php-svn/php-src/sapi/cli/test.php"  
string(43) "/home/sam/php-svn/php-src/sapi/cli/test.php"

Where as if you request / the output is:

string(45) "/home/sam/php-svn/php-src/sapi/cli/router.php"  
string(45) "/home/sam/php-svn/php-src/sapi/cli/router.php"

Even though we've been routed to what is essentially test.php, it is not named 
as our SCRIPT_FILENAME, which is what is desired.

It should be noted that, index code should not be placed in the router.php file 
in the documentation, instead, have it served directly using `return false` OR 
include it after a routing rule of some sort.  
It should also be well noted the real purpose of the router script, being that 
it shouldn't hold your application rules only routing rules, perhaps making it 
distinguishable through a different file extension in the docs?

Thank you for your bug report. This issue has already been fixed
in the latest released version of PHP, which you can download at 
http://www.php.net/downloads.php

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.