php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #54040 Logical && where & probably needed in spl_iterators.c
Submitted: 2011-02-18 02:34 UTC Modified: 2011-02-20 17:10 UTC
From: sixd@php.net Assigned: felipe (profile)
Status: Closed Package: SPL related
PHP Version: 5.3.6RC1 OS: Generic
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2011-02-18 02:34 UTC] sixd@php.net 
Description:
------------
The HP/UX compiler reports the following:

"/home/users/cjones/php-5.3.5/ext/spl/spl_iterators.c", line 2742: warning #4277-D: 
          logical AND with a constant, do you mean to use '&'?
        if ((flags && CIT_FULL_CACHE) != 0 && (intern->u.caching.flags & CIT_FULL_CACHE) == 0) {
                   ^

Similar nearby code uses '&' so the warning is probably accurate.
Can this code be reviewed and fixed if the test is incorrect?

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-02-20 17:09 UTC] felipe@php.net 
Automatic comment from SVN on behalf of felipe
Revision: http://svn.php.net/viewvc/?view=revision&revision=308503
Log: - Fixed bug #54040 (Logical && where & probably needed in spl_iterators)
 [2011-02-20 17:10 UTC] felipe@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: felipe
 [2011-02-20 17:10 UTC] felipe@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Apr 27 01:01:30 2024 UTC