PHP :: Request #50087 :: [PATCH] - NSAPI performance improvements

Request #50087	[PATCH] - NSAPI performance improvements
Submitted:	2009-11-05 10:38 UTC	Modified:	2009-11-12 15:20 UTC
From:	yoarvi at gmail dot com	Assigned:	thetaphi (profile)
Status:	Closed	Package:	Feature/Change Request
PHP Version:	6SVN-2009-11-05 (SVN)	OS:	Solaris 5.10 (SPARC)
Private report:	No	CVE-ID:	None

View Developer Edit

[2009-11-05 10:38 UTC] yoarvi at gmail dot com

Description:
------------
The PHP NSAPI plugin for Sun Web Server could be made more efficient by applying the following patches that were previously posted to the internals mailing list.

1. Use pool_malloc/pool_free instead of MALLOC/FREE
   http://marc.info/?l=php-internals&m=125690295631596&w=2

2. Use pool_strdup instead of STRDUP
   http://marc.info/?l=php-internals&m=125690359232507&w=2

3. Remove unnecessary strdup calls
   http://marc.info/?l=php-internals&m=125690315831950&w=2

4. Avoid unnecessary strlen
   http://marc.info/?l=php-internals&m=125690329932150&w=2

Expected result:
----------------
Improved performance.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2009-11-05 15:58 UTC] thetaphi@php.net

I will look into it!

[2009-11-12 15:12 UTC] thetaphi@php.net

The patch nsapi3.patch was invalid, because it used an unitialized "pos" variable. Also it registered the wrong contents for SCRIPT_NAME. I fixed this.

I will commit soon to 5.3 and trunk.

[2009-11-12 15:19 UTC] svn@php.net

Automatic comment from SVN on behalf of thetaphi
Revision: http://svn.php.net/viewvc/?view=revision&revision=290582
Log: Fix bug #50087: NSAPI performance improvements

[2009-11-12 15:20 UTC] thetaphi@php.net

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Fixed in 5.3 snapshot and trunk snapshot. 5.3.1 will not contain this patch.

[2009-11-12 17:13 UTC] svn@php.net

Automatic comment from SVN on behalf of thetaphi
Revision: http://svn.php.net/viewvc/?view=revision&revision=290591
Log: As I am working on it, further improvement for bug #50087

	php.net \| support \| documentation \| report a bug \| advanced search \| search howto \| statistics \| random bug \| login
go to bug id or search bugs for


Copyright © 2001-2025 The PHP Group All rights reserved.	Last updated: Sat Feb 22 17:01:28 2025 UTC