php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #49464 php_sockets build broken
Submitted: 2009-09-04 03:44 UTC Modified: 2009-09-04 19:53 UTC
From: raulsalitrero at gmail dot com Assigned: pajoye (profile)
Status: Closed Package: Compile Failure
PHP Version: 5.3SVN-2009-09-04 (SVN) OS: win32 only - Windows Xp SP3
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2009-09-04 03:44 UTC] raulsalitrero at gmail dot com 
Description:
------------
php_sockets.dll build is broken in win vc9, with the next error

ext\sockets\sockets.c(327) : error C2491: 'php_sockets_le_socket' : definition of dllimport function not allowed

tried building the last svn source with the same result.

using vc9 to compile, the error is also observable in the windows sanpshots compile logs 

the bug was introduced in revision: 287911 - export le_socket from ext/sockets
changing files:
-/php/php-src/branches/PHP_5_3/ext/sockets/php_sockets.h
-/php/php-src/branches/PHP_5_3/ext/sockets/sockets.c

Reproduce code:
---------------
use nmake to compile with vc9 compiler

Expected result:
----------------
php_sockets.dll is built

Actual result:
--------------
php_sockets.dll is missing from the result build

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2009-09-04 10:26 UTC] kalle@php.net 
The fix for this is pretty simple:
http://pastie.org/605649

However this C2491 only occurs when building sockets shared because of the wrong exporting declarings used
 [2009-09-04 15:50 UTC] raulsalitrero at gmail dot com 
i've just tried it, it works now.
thanks.
 [2009-09-04 19:53 UTC] svn@php.net 
Automatic comment from SVN on behalf of pajoye
Revision: http://svn.php.net/viewvc/?view=revision&revision=288067
Log: - #49464, fix build
 [2009-09-04 19:53 UTC] pajoye@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 [2009-10-09 14:22 UTC] svn@php.net 
Automatic comment from SVN on behalf of pajoye
Revision: http://svn.php.net/viewvc/?view=revision&revision=289417
Log: - merge: #49464, fix build
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Apr 25 01:01:30 2024 UTC