|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
[2007-10-18 14:39 UTC] scottmac@php.net
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Thu Oct 30 22:00:01 2025 UTC |
Description: ------------ When shuffle() function is called with two arguments (ie. one argument more than expected), it performs the operation of shuffling and donot throws warning message stating for more than expected number of arguments , as we see with other functions like end() etc. Also when shuffle() is called with zero argument(ie. one less than minimum number of argument required) the warning message is not proper and do not say anything about the insufficient number of arguments. The following can be added in the beginning of the function definition for PHP5 to check for the above scenarios: if (ZEND_NUM_ARGS() != 1) { WRONG_PARAM_COUNT; } Reproduce code: --------------- <?php $arr = array(1,2,3,4,5); var_dump( shuffle() ); var_dump( shuffle($arr, 2) ); ?> Expected result: ---------------- Warning: Wrong parameter count for shuffle() in %s on line %d NULL Warning: Wrong parameter count for shuffle() in %s on line %d NULL Actual result: -------------- Warning: shuffle(): could not obtain parameters for parsing in %s on line %d bool(false) bool(true)