|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2005-03-07 00:46 UTC] joh at deworks dot net
Description:
------------
The "running" field of the status array returned by proc_get_status() is always TRUE after the execution of the command is finished. As the manual says, running should be "TRUE if the process is still running, FALSE if it has terminated". What is strange is that at some point of the command execution, it's false. Maybe it's value is the opposite of what the manual says?
Reproduce code:
---------------
(Best run from the command line)
$handle = proc_open("ls", array(2 => array("pipe", "r")), $pipes);
while (true) {
$status = proc_get_status($handle); var_dump($status["running"]);
sleep(1);
}
Expected result:
----------------
bool(false)
<output of the command>
bool(true)
bool(false)
bool(false)
...
Actual result:
--------------
bool(true)
<output of the command>
bool(false)
bool(true)
bool(true)
...
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Thu Nov 21 08:01:29 2024 UTC |
It really looks that proc_get_status() doesn't take into account the result of waitpid() and still returns TRUE even when child process is already dead. Wez, take a look at the patch, plz. Index: proc_open.c =================================================================== RCS file: /repository/php-src/ext/standard/proc_open.c,v retrieving revision 1.31 diff -u -p -d -r1.31 proc_open.c --- proc_open.c 21 Feb 2005 09:50:48 -0000 1.31 +++ proc_open.c 7 Mar 2005 01:04:08 -0000 @@ -414,6 +414,10 @@ PHP_FUNCTION(proc_get_status) stopsig = WSTOPSIG(wstatus); } } + else if (wait_pid == -1) { + /* -1 means such child doesn't exist i.e. it already exited */ + running = 0; + } #endif add_assoc_bool(return_value, "running", running);