php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #27093 Incorrect casts in oci8.c prevent compiling with Oracle 10g
Submitted: 2004-01-30 02:04 UTC Modified: 2004-02-03 14:51 UTC
From: cjbj at hotmail dot com Assigned: tony2001 (profile)
Status: Closed Package: OCI8 related
PHP Version: 4CVS-2004-01-30 (stable) OS: RH Linux 3
Private report: No CVE-ID: None
 [2004-01-30 02:04 UTC] cjbj at hotmail dot com
Description:
------------
The casts to "(dword *)" in OCICollAppend() and OCICollAssignElem()
calls in oci8.c should be changed to "(dvoid *)" to match the
prototypes.  

Without this correction the file will fail to compile in Oracle 10g:
the very obsolete dword no longer appears to be defined in oratypes.h.



Actual result:
--------------
Without this fix, compiling php4-STABLE-200401300430 with --enable-oci8 gives:

  /home/cjbj/php/ext/oci8/oci8.c:4833: `dword' undeclared (first use in this function)

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-02-01 19:22 UTC] cjbj at hotmail dot com
Diff -cw gives:

*** oci8.c.orig	2004-01-27 01:08:29.000000000 +1100
--- oci8.c	2004-02-02 11:24:46.000000000 +1100
***************
*** 4833,4839 ****
  			CALL_OCI_RETURN(connection->error, OCICollAppend(
  				  connection->session->pEnv, 
  				  connection->pError, 
! 				  (dword *)0, 
  				  &null_ind, 
  				  coll->coll));
  			if (connection->error) {
--- 4833,4839 ----
              CALL_OCI_RETURN(connection->error, OCICollAppend(
                    connection->session->pEnv,
                    connection->pError,
!                   (dvoid *)0,
                    &null_ind,
                    coll->coll));
              if (connection->error) {
***************
*** 5139,5145 ****
  				  connection->session->pEnv, 
  				  connection->pError, 
  				  ndx, 
! 				  (dword *)0, 
  				  &null_ind, 
  				  coll->coll));
  			if (connection->error) {
--- 5139,5145 ----
                    connection->session->pEnv,
                    connection->pError,
                    ndx,
!                   (dvoid *)0,
                    &null_ind,
                    coll->coll));
              if (connection->error) {
***************
*** 5172,5178 ****
  							connection->session->pEnv, 
  							connection->pError, 
  							ndx, 
! 							(dword *)&dt, 
  							&new_ind, 
  							coll->coll));
  
--- 5172,5178 ----
                              connection->session->pEnv,
                              connection->pError,
                              ndx,
!                             (dvoid *)&dt,
                              &new_ind,
                              coll->coll));
  
***************
*** 5200,5206 ****
  							connection->session->pEnv, 
  							connection->pError, 
  							ndx, 
! 							(dword *)ocistr, 
  							&new_ind, 
  							coll->coll));
  
--- 5200,5206 ----
                              connection->session->pEnv,
                              connection->pError,
                              ndx,
!                             (dvoid *)ocistr,
                              &new_ind,
                              coll->coll));
  
***************
*** 5239,5245 ****
  							connection->session->pEnv, 
  							connection->pError, 
  							ndx, 
! 							(dword *)&num, 
  							&new_ind, 
  							coll->coll));
  
--- 5239,5245 ----
                              connection->session->pEnv,
                              connection->pError,
                              ndx,
!                             (dvoid *)&num,
                              &new_ind,
                              coll->coll));
 [2004-02-02 00:39 UTC] cjbj at hotmail dot com
To compile with Oracle 10g also see http://bugs.php.net/27117
 [2004-02-03 08:31 UTC] sniper@php.net
Assigned to the maintainer of ext/oci8

 [2004-02-03 14:51 UTC] sniper@php.net
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Mar 29 11:01:29 2024 UTC