php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #26528 xml_parse_into_struct does not unescape attribute values
Submitted: 2003-12-04 17:00 UTC Modified: 2003-12-04 20:13 UTC
From: archie at dellroad dot org Assigned:
Status: Closed Package: XML related
PHP Version: 5.0.0b2 (beta2) OS: Linux redhat 9
Private report: No CVE-ID: None
 [2003-12-04 17:00 UTC] archie at dellroad dot org
Description:
------------
When the function xml_parse_into_struct() is used,
XML attribute values that contain escaped characters
in them are not properly un-escaped.

E.g. suppose the tag is:

  <governor name="Jesse &quot;The Body&quot; Ventura"/>

Then the attribute is returned still escaped, as

  Jesse &quot;The Body&quot; Ventura

rather than

  Jesse "The Body" Ventura

like it should be.

This function is supposed to parse
the XML, and &-encodings are part of XML, so it should
properly decode them!

Here's ldd output for my test version of PHP:

$ ldd ~/php-5.0.0b2/sapi/cli/php
        libcrypt.so.1 => /lib/libcrypt.so.1 (0x40017000)
        librt.so.1 => /lib/i686/librt.so.1 (0x40064000)
        libm.so.6 => /lib/i686/libm.so.6 (0x4007f000)
        libmysqlclient.so.10 => /usr/lib/mysql/libmysqlclient.so.10 (0x400cc000)        libresolv.so.2 => /lib/libresolv.so.2 (0x40103000)
        libdl.so.2 => /lib/libdl.so.2 (0x40116000)
        libnsl.so.1 => /lib/libnsl.so.1 (0x4011a000)
        libz.so.1 => /usr/lib/libz.so.1 (0x40140000)
        libxml2.so.2 => /usr/local/lib/libxml2.so.2 (0x4014e000)
        libpthread.so.0 => /lib/i686/libpthread.so.0 (0x40237000)
        libc.so.6 => /lib/i686/libc.so.6 (0x40287000)
        /lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)




Reproduce code:
---------------
<?php
$sample =
  "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
$parser = xml_parser_create();
$res = xml_parse_into_struct($parser,$sample,$vals,$index);
xml_parser_free($parser);
var_dump($vals); 
?>


Expected result:
----------------
array(1) {
  [0]=>
  array(4) {
    ["tag"]=>
    string(4) "TEST"
    ["type"]=>
    string(8) "complete"
    ["level"]=>
    int(1)
    ["attributes"]=>
    array(1) {
      ["ATTR"]=>
      string(16) "angle<bracket"
    }
  }
}


Actual result:
--------------
array(1) {
  [0]=>
  array(4) {
    ["tag"]=>
    string(4) "TEST"
    ["type"]=>
    string(8) "complete"
    ["level"]=>
    int(1)
    ["attributes"]=>
    array(1) {
      ["ATTR"]=>
      string(16) "angle&lt;bracket"
    }
  }
}



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2003-12-04 20:13 UTC] iliaa@php.net
This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Mar 19 09:01:30 2024 UTC